Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

My raid check also ran through cleanly, so feel free to add my Tested-By: Cheers David Quoting Dominik Brodowski : On Tue, Aug 08, 2017 at 09:36:14AM +0200, Dominik Brodowski wrote: On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > On Mon, Aug 07 2017,

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

My raid check also ran through cleanly, so feel free to add my Tested-By: Cheers David Quoting Dominik Brodowski : On Tue, Aug 08, 2017 at 09:36:14AM +0200, Dominik Brodowski wrote: On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > On Mon, Aug 07 2017, Dominik Brodowski wrote: > >

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08, 2017 at 09:36:14AM +0200, Dominik Brodowski wrote: > On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > > On Mon, Aug 07 2017, Dominik Brodowski wrote: > > > > > Neil, Shaohua, > > > > > > following up on David R's bug message: I have observed something similar > > > on

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08, 2017 at 09:36:14AM +0200, Dominik Brodowski wrote: > On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > > On Mon, Aug 07 2017, Dominik Brodowski wrote: > > > > > Neil, Shaohua, > > > > > > following up on David R's bug message: I have observed something similar > > > on

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

I will apply this to my home server this evening (BST) and set off a check. Will have results tomorrow. Thanks for the fix! David Quoting NeilBrown : On Mon, Aug 07 2017, Dominik Brodowski wrote: Neil, Shaohua, following up on David R's bug message: I have observed

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

I will apply this to my home server this evening (BST) and set off a check. Will have results tomorrow. Thanks for the fix! David Quoting NeilBrown : On Mon, Aug 07 2017, Dominik Brodowski wrote: Neil, Shaohua, following up on David R's bug message: I have observed something similar on

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > On Mon, Aug 07 2017, Dominik Brodowski wrote: > > > Neil, Shaohua, > > > > following up on David R's bug message: I have observed something similar > > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > > metal

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08, 2017 at 05:01:28PM +1000, NeilBrown wrote: > On Mon, Aug 07 2017, Dominik Brodowski wrote: > > > Neil, Shaohua, > > > > following up on David R's bug message: I have observed something similar > > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > > metal

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Shaouhua, ( really CC'ing Tejun now ) On Mon, Aug 07, 2017 at 09:51:03PM -0700, Shaohua Li wrote: > On Mon, Aug 07, 2017 at 01:20:25PM +0200, Dominik Brodowski wrote: > > Neil, Shaohua, > > > > following up on David R's bug message: I have observed something similar > > on v4.12.[345] and

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Shaouhua, ( really CC'ing Tejun now ) On Mon, Aug 07, 2017 at 09:51:03PM -0700, Shaohua Li wrote: > On Mon, Aug 07, 2017 at 01:20:25PM +0200, Dominik Brodowski wrote: > > Neil, Shaohua, > > > > following up on David R's bug message: I have observed something similar > > on v4.12.[345] and

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08 2017, David R wrote: > Quoting Shaohua Li : > >> Spent some time to check this one, unfortunately I can't find how that patch >> makes rcu stall. the percpu part looks good to me too. Can you >> double check if >> reverting 4ad23a976413aa57 makes the issue go

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Tue, Aug 08 2017, David R wrote: > Quoting Shaohua Li : > >> Spent some time to check this one, unfortunately I can't find how that patch >> makes rcu stall. the percpu part looks good to me too. Can you >> double check if >> reverting 4ad23a976413aa57 makes the issue go away? When the rcu

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Ignore me. The increment and decrement of sync_checkers should protect switch_to_percpu(). Sigh. Quoting David R : Quoting Shaohua Li : Spent some time to check this one, unfortunately I can't find how that patch makes rcu stall. the percpu part

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Ignore me. The increment and decrement of sync_checkers should protect switch_to_percpu(). Sigh. Quoting David R : Quoting Shaohua Li : Spent some time to check this one, unfortunately I can't find how that patch makes rcu stall. the percpu part looks good to me too. Can you double

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Mon, Aug 07 2017, Dominik Brodowski wrote: > Neil, Shaohua, > > following up on David R's bug message: I have observed something similar > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > metal partitions, /dev/sdaX and /dev/sdbY linked together). In case it >

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Mon, Aug 07 2017, Dominik Brodowski wrote: > Neil, Shaohua, > > following up on David R's bug message: I have observed something similar > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > metal partitions, /dev/sdaX and /dev/sdbY linked together). In case it >

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Quoting Shaohua Li : Spent some time to check this one, unfortunately I can't find how that patch makes rcu stall. the percpu part looks good to me too. Can you double check if reverting 4ad23a976413aa57 makes the issue go away? When the rcu stall happens, what the

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Quoting Shaohua Li : Spent some time to check this one, unfortunately I can't find how that patch makes rcu stall. the percpu part looks good to me too. Can you double check if reverting 4ad23a976413aa57 makes the issue go away? When the rcu stall happens, what the

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Mon, Aug 07, 2017 at 01:20:25PM +0200, Dominik Brodowski wrote: > Neil, Shaohua, > > following up on David R's bug message: I have observed something similar > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > metal partitions, /dev/sdaX and /dev/sdbY linked together).

Re: [MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

On Mon, Aug 07, 2017 at 01:20:25PM +0200, Dominik Brodowski wrote: > Neil, Shaohua, > > following up on David R's bug message: I have observed something similar > on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare > metal partitions, /dev/sdaX and /dev/sdbY linked together).

[MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Neil, Shaohua, following up on David R's bug message: I have observed something similar on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare metal partitions, /dev/sdaX and /dev/sdbY linked together). In case it matters: Further upwards are cryptsetup, a DM volume group, then

[MD] Crash with 4.12+ kernel and high disk load -- bisected to 4ad23a976413: MD: use per-cpu counter for writes_pending

Neil, Shaohua, following up on David R's bug message: I have observed something similar on v4.12.[345] and v4.13-rc4, but not on v4.11. This is a RAID1 (on bare metal partitions, /dev/sdaX and /dev/sdbY linked together). In case it matters: Further upwards are cryptsetup, a DM volume group, then