Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-17 Thread Trond Myklebust
On Sat, 2007-09-15 at 01:43 +1000, Greg Banks wrote: > On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: > > If Irix isn't clearing these bits > > on a write then it might be good to see if they can fix that... > > I think first you'd have to mount a serious argument that it's broken,

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-17 Thread Trond Myklebust
On Sat, 2007-09-15 at 01:43 +1000, Greg Banks wrote: On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: If Irix isn't clearing these bits on a write then it might be good to see if they can fix that... I think first you'd have to mount a serious argument that it's broken, more

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Sat, 15 Sep 2007 01:43:45 +1000 Greg Banks <[EMAIL PROTECTED]> wrote: > On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: > > On Sat, 15 Sep 2007 00:40:33 +1000 > > Greg Banks <[EMAIL PROTECTED]> wrote: > > > > > > > Ok, you convinced me. > > > > Right. When I was first looking

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: > On Sat, 15 Sep 2007 00:40:33 +1000 > Greg Banks <[EMAIL PROTECTED]> wrote: > > > > Ok, you convinced me. > > Right. When I was first looking at this, I considered some similar > approaches, but hit roadblocks with all of them. The

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Sat, 15 Sep 2007 00:40:33 +1000 Greg Banks <[EMAIL PROTECTED]> wrote: > On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote: > > On Fri, 14 Sep 2007 23:09:24 +1000 > > Greg Banks <[EMAIL PROTECTED]> wrote: > > > > > On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: > > > >

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote: > On Fri, 14 Sep 2007 23:09:24 +1000 > Greg Banks <[EMAIL PROTECTED]> wrote: > > > On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: > > > On Fri, 14 Sep 2007 20:25:45 +1000 > > > Greg Banks <[EMAIL PROTECTED]> wrote: > > >

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Fri, 14 Sep 2007 23:09:24 +1000 Greg Banks <[EMAIL PROTECTED]> wrote: > On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: > > On Fri, 14 Sep 2007 20:25:45 +1000 > > Greg Banks <[EMAIL PROTECTED]> wrote: > > > > > I'm curious about the reasons behind this change. You mention > > >

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: > On Fri, 14 Sep 2007 20:25:45 +1000 > Greg Banks <[EMAIL PROTECTED]> wrote: > > > I'm curious about the reasons behind this change. You mention > > credential issues; how exactly is it that you have the correct creds > > to perform a

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Fri, 14 Sep 2007 20:25:45 +1000 Greg Banks <[EMAIL PROTECTED]> wrote: > On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote: > > If the ATTR_KILL_S*ID bits are set then any mode change is only for > > clearing the setuid/setgid bits. For NFS skip the mode change and > > let the server

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote: > If the ATTR_KILL_S*ID bits are set then any mode change is only for > clearing the setuid/setgid bits. For NFS skip the mode change and > let the server handle it. You're assuming the server will remove setuid and setgid bits on

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote: If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For NFS skip the mode change and let the server handle it. You're assuming the server will remove setuid and setgid bits on WRITE? I

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Fri, 14 Sep 2007 20:25:45 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote: If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For NFS skip the mode change and let the server handle

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: On Fri, 14 Sep 2007 20:25:45 +1000 Greg Banks [EMAIL PROTECTED] wrote: I'm curious about the reasons behind this change. You mention credential issues; how exactly is it that you have the correct creds to perform a WRITE rpc

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Fri, 14 Sep 2007 23:09:24 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: On Fri, 14 Sep 2007 20:25:45 +1000 Greg Banks [EMAIL PROTECTED] wrote: I'm curious about the reasons behind this change. You mention credential

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote: On Fri, 14 Sep 2007 23:09:24 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: On Fri, 14 Sep 2007 20:25:45 +1000 Greg Banks [EMAIL PROTECTED] wrote: I'm curious

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Sat, 15 Sep 2007 00:40:33 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote: On Fri, 14 Sep 2007 23:09:24 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote: On Fri, 14 Sep

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Greg Banks
On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: On Sat, 15 Sep 2007 00:40:33 +1000 Greg Banks [EMAIL PROTECTED] wrote: Ok, you convinced me. Right. When I was first looking at this, I considered some similar approaches, but hit roadblocks with all of them. The only real

Re: [NFS] [PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

2007-09-14 Thread Jeff Layton
On Sat, 15 Sep 2007 01:43:45 +1000 Greg Banks [EMAIL PROTECTED] wrote: On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote: On Sat, 15 Sep 2007 00:40:33 +1000 Greg Banks [EMAIL PROTECTED] wrote: Ok, you convinced me. Right. When I was first looking at this, I considered