Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-13 Thread Fabio M. De Francesco
On Tuesday, April 13, 2021 9:39:44 AM CEST Greg Kroah-Hartman wrote: > On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > > Removed camelcase in (some) symbols. Further work is needed. > > What symbols did you do this for? What did you change them from and to?> > > Be

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-13 Thread Greg Kroah-Hartman
On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > Removed camelcase in (some) symbols. Further work is needed. What symbols did you do this for? What did you change them from and to? Be specific, and try to do only one structure at a time at the most, trying to review

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-12 Thread Matthew Wilcox
On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > Removed camelcase in (some) symbols. Further work is needed. What would be more useful for this driver is making it use drivers/net/wireless/realtek/rtlwifi/btcoexist/ which has already graduated out of staging. I haven't

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-07 Thread Fabio M. De Francesco
On Wednesday, April 7, 2021 7:27:38 PM CEST Greg KH wrote: > On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > > names of static functions in order to not break the driver's code. > > > >

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > names of static functions in order to not break the driver's code. > > Signed-off-by: Fabio M. De Francesco > --- >

[Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase

2021-04-07 Thread Fabio M. De Francesco
Remove camelcase. Issue detected by checkpatch.pl. For now, change only names of static functions in order to not break the driver's code. Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 44 1 file changed, 22 insertions(+), 22