Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Joe Perches
On Wed, 2017-02-22 at 09:46 +0530, Arushi Singhal wrote: > On Wed, Feb 22, 2017 at 12:12 AM, Joe Perches wrote: > > > On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Feb 2017, Arushi Singhal wrote: > > > > > > > Error was reported by

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Joe Perches
On Wed, 2017-02-22 at 09:46 +0530, Arushi Singhal wrote: > On Wed, Feb 22, 2017 at 12:12 AM, Joe Perches wrote: > > > On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Feb 2017, Arushi Singhal wrote: > > > > > > > Error was reported by checkpatch.pl as > > > >

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote: > > On Tue, 21 Feb 2017, Arushi Singhal wrote: > > > Error was reported by checkpatch.pl as > > WARNING: Avoid multiple line dereference... > > if there is boolean operator then it is fixed by Splitting line at > > boolean operator. > >

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 18:40 +0100, Julia Lawall wrote: > > On Tue, 21 Feb 2017, Arushi Singhal wrote: > > > Error was reported by checkpatch.pl as > > WARNING: Avoid multiple line dereference... > > if there is boolean operator then it is fixed by Splitting line at > > boolean operator. > >

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > if there is boolean operator then it is fixed by Splitting line at > boolean operator. This is massively execeeding the 80 character boundary, and not for

Re: [Outreachy kernel] [PATCH] staging: xgifb: correct the multiple line dereference to fix coding stye errors

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > if there is boolean operator then it is fixed by Splitting line at > boolean operator. This is massively execeeding the 80 character boundary, and not for