Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

2017-09-08 Thread Julia Lawall
Maybe "Rewrite comparison to NULL pointer" in the subject to include what was done, not just code was touched. On Fri, 8 Sep 2017, Harsha Sharma wrote: > Makes code more concise and readable Makes -> Make. Commit logs should be written in the imperative, like you are telling someone what to

Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

2017-09-08 Thread Julia Lawall
Maybe "Rewrite comparison to NULL pointer" in the subject to include what was done, not just code was touched. On Fri, 8 Sep 2017, Harsha Sharma wrote: > Makes code more concise and readable Makes -> Make. Commit logs should be written in the imperative, like you are telling someone what to