On Sat, 18 Feb 2017, simran singhal wrote:

> This patch removes the explicit NULL comparison. This issue was found by
> checkpatch.
>
> Signed-off-by: simran singhal <singhalsimr...@gmail.com>

Acked-by: Julia Lawall <julia.law...@lip6.fr>

> ---
>
>  v2:
>    -Modified commit message
>
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c 
> b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 20260af..bdbd21c 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -83,12 +83,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device 
> *ieee, u8 *Dst,
>       netdev_dbg(ieee->dev, "%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n",
>                  __func__, type, Dst, ieee->dev);
>
> -     if (pBA == NULL) {
> +     if (!pBA) {
>               netdev_warn(ieee->dev, "pBA is NULL\n");
>               return NULL;
>       }
>       skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
> -     if (skb == NULL)
> +     if (!skb)
>               return NULL;
>
>       memset(skb->data, 0, sizeof(struct rtllib_hdr_3addr));
> @@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device 
> *ieee, u8 *dst,
>       DelbaParamSet.field.TID = pBA->BaParamSet.field.TID;
>
>       skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
> -     if (skb == NULL)
> +     if (!skb)
>               return NULL;
>
>       skb_reserve(skb, ieee->tx_headroom);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups 
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To post to this group, send email to outreachy-ker...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20170218134248.GA21186%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Reply via email to