On Sun, 19 Feb 2017, Arushi Singhal wrote:
> > Hi Greg > I think we cannot indent the text otherwise, the print statement will be > different as it should be There are newlines in the printed string. I suspect that there is no need to print them all at once. Actually, your change removed spaces inside a string, so it did change the form of the poutput. Also, remember not to top post :) julia > Thanks > > On Saturday, February 18, 2017 at 10:27:19 PM UTC+5:30, gregkh wrote: > On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces > at the > > start of a line > > > > Signed-off-by: Arushi Singhal <arushising...@gmail.com> > > --- > > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c > > index 819e08b5fa91..3b2e28749b63 100644 > > --- a/drivers/staging/ks7010/ks_hostif.c > > +++ b/drivers/staging/ks7010/ks_hostif.c > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private > *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n > \ > > - essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > +essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > So don't just remove the spaces, fix it correctly with the > proper > indentation please. > > thanks, > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web > visithttps://groups.google.com/d/msgid/outreachy-kernel/df1dbfa6-0823-4899-b1b7- > 4358b18575be%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > >