Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote: > Ah, it was only below the "---" line, so I'll skip the resending > unless you want me > to add a comment in the Kconfig file. Nah no need, really. Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote: > Ah, it was only below the "---" line, so I'll skip the resending > unless you want me > to add a comment in the Kconfig file. Nah no need, really. Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:16:10AM +0200, Arnd Bergmann wrote: > We use this construct in many places these days. A few years ago I added > a comment whenever I added an instance, but most others don't so I treat > it as an idiom now. > > "depends on X" means that if X=m, the current symbol can

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:16:10AM +0200, Arnd Bergmann wrote: > We use this construct in many places these days. A few years ago I added > a comment whenever I added an instance, but most others don't so I treat > it as an idiom now. > > "depends on X" means that if X=m, the current symbol can

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:16 AM, Arnd Bergmann wrote: > On Wed, Jul 26, 2017 at 11:08 AM, Johannes Thumshirn > wrote: >> On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: >>> I originally sent the patch in March 2013, the day after the broken >>

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:16 AM, Arnd Bergmann wrote: > On Wed, Jul 26, 2017 at 11:08 AM, Johannes Thumshirn > wrote: >> On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: >>> I originally sent the patch in March 2013, the day after the broken >>

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:08 AM, Johannes Thumshirn wrote: > On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: >> I originally sent the patch in March 2013, the day after the broken >^ 2017? Oops. Let me resend that. >> +

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:08 AM, Johannes Thumshirn wrote: > On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: >> I originally sent the patch in March 2013, the day after the broken >^ 2017? Oops. Let me resend that. >> + depends on

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: > I originally sent the patch in March 2013, the day after the broken ^ 2017? > + depends on NVME_TARGET_FC || NVME_TARGET_FC=n > + depends on NVME_FC || NVME_FC=n OK Kconfig is black

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Fri, Jul 21, 2017 at 10:53:46PM +0200, Arnd Bergmann wrote: > I originally sent the patch in March 2013, the day after the broken ^ 2017? > + depends on NVME_TARGET_FC || NVME_TARGET_FC=n > + depends on NVME_FC || NVME_FC=n OK Kconfig is black

[PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

When LPFC is built-in but NVMe is a loadable module, we fail to link the kernel: drivers/scsi/built-in.o: In function `lpfc_nvme_create_localport': (.text+0x156a82): undefined reference to `nvme_fc_register_localport' drivers/scsi/built-in.o: In function `lpfc_nvme_destroy_localport':

[PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

When LPFC is built-in but NVMe is a loadable module, we fail to link the kernel: drivers/scsi/built-in.o: In function `lpfc_nvme_create_localport': (.text+0x156a82): undefined reference to `nvme_fc_register_localport' drivers/scsi/built-in.o: In function `lpfc_nvme_destroy_localport':