Re: [PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Stephen Rothwell
Hi Jochen, Just a couple of suggestions. On Fri, 28 Dec 2007 16:13:11 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > > +int __init pq_wdt_early_init(void) > +{ > > + data = of_get_property(soc, "bus-frequency", NULL); > + if (!data) { > + of_node_put(soc); > +

[PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Jochen Friedrich
The PowerQUICC series has a watchdog which can be activated by the boot loader and then needs to be reset in regular intervals. Once the watchdog is enabled, it can't be disabled anymore. This patch adds support for this kind of watchdog. An early init function is provided to manually reset the

[PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Jochen Friedrich
The PowerQUICC series has a watchdog which can be activated by the boot loader and then needs to be reset in regular intervals. Once the watchdog is enabled, it can't be disabled anymore. This patch adds support for this kind of watchdog. An early init function is provided to manually reset the

Re: [PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Stephen Rothwell
Hi Jochen, Just a couple of suggestions. On Fri, 28 Dec 2007 16:13:11 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: +int __init pq_wdt_early_init(void) +{ + data = of_get_property(soc, bus-frequency, NULL); + if (!data) { + of_node_put(soc); +