Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-07 Thread Ben Whitten
On 6 December 2017 at 20:07, Ben Whitten wrote: > Hi Jacek, > > On 5 December 2017 at 20:38, Jacek Anaszewski > wrote: >> Hi Ben, >> >> On 12/05/2017 12:19 PM, Ben Whitten wrote: >>> From: Ben Whitten >>> >>> The patch

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-07 Thread Ben Whitten
On 6 December 2017 at 20:07, Ben Whitten wrote: > Hi Jacek, > > On 5 December 2017 at 20:38, Jacek Anaszewski > wrote: >> Hi Ben, >> >> On 12/05/2017 12:19 PM, Ben Whitten wrote: >>> From: Ben Whitten >>> >>> The patch was converted to led_blink_oneshot, in doing so we find that the >>>

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-06 Thread Ben Whitten
Hi Jacek, On 5 December 2017 at 20:38, Jacek Anaszewski wrote: > Hi Ben, > > On 12/05/2017 12:19 PM, Ben Whitten wrote: >> From: Ben Whitten >> >> The patch was converted to led_blink_oneshot, in doing so we find that the >> behaviour has

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-06 Thread Ben Whitten
Hi Jacek, On 5 December 2017 at 20:38, Jacek Anaszewski wrote: > Hi Ben, > > On 12/05/2017 12:19 PM, Ben Whitten wrote: >> From: Ben Whitten >> >> The patch was converted to led_blink_oneshot, in doing so we find that the >> behaviour has changed. As I dont want to break 'userspace' led

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Jacek Anaszewski
Hi Ben, On 12/05/2017 12:19 PM, Ben Whitten wrote: > From: Ben Whitten > > The patch was converted to led_blink_oneshot, in doing so we find that the > behaviour has changed. As I dont want to break 'userspace' led behaviour this > patch shouldn't be merged as is. Open to

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Jacek Anaszewski
Hi Ben, On 12/05/2017 12:19 PM, Ben Whitten wrote: > From: Ben Whitten > > The patch was converted to led_blink_oneshot, in doing so we find that the > behaviour has changed. As I dont want to break 'userspace' led behaviour this > patch shouldn't be merged as is. Open to suggestions. > >

[PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Ben Whitten
From: Ben Whitten This commit introduces a NETDEV trigger for named device activity. Available triggers are link, rx, and tx. Signed-off-by: Ben Whitten --- Changes in v2: Sort includes and redate documentation Correct licence Remove macro and

[PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Ben Whitten
From: Ben Whitten This commit introduces a NETDEV trigger for named device activity. Available triggers are link, rx, and tx. Signed-off-by: Ben Whitten --- Changes in v2: Sort includes and redate documentation Correct licence Remove macro and replace with generic function using enums Convert

[PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Ben Whitten
From: Ben Whitten The patch was converted to led_blink_oneshot, in doing so we find that the behaviour has changed. As I dont want to break 'userspace' led behaviour this patch shouldn't be merged as is. Open to suggestions. Given an interval of 50ms and heavy throughput,

[PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Ben Whitten
From: Ben Whitten The patch was converted to led_blink_oneshot, in doing so we find that the behaviour has changed. As I dont want to break 'userspace' led behaviour this patch shouldn't be merged as is. Open to suggestions. Given an interval of 50ms and heavy throughput, the previous