Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-11-30 Thread Grant Likely
On Fri, 5 Oct 2012 14:20:55 +0200, Drasko DRASKOVIC wrote: > Hi all, > please find a patch that adds IRQ edge set-up mechanism to sysfs that > can be called from the kernel. > > This functionality can be very useful for embedded systems, as it > permits kernel to do GPIO set-up during boot

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-11-30 Thread Grant Likely
On Fri, 5 Oct 2012 14:20:55 +0200, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: Hi all, please find a patch that adds IRQ edge set-up mechanism to sysfs that can be called from the kernel. This functionality can be very useful for embedded systems, as it permits kernel to do GPIO

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-11 Thread Linus Walleij
On Tue, Oct 9, 2012 at 4:22 PM, Drasko DRASKOVIC wrote: > [Me] >> So can you explain exactly why userspace want to configure >> GPIO pins in interrupt mode, when there is no way whatsoever >> for userspace to handle these IRQs? > > Maybe I understand something wrong, but explicit configuration of

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-11 Thread Linus Walleij
On Tue, Oct 9, 2012 at 4:22 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: [Me] So can you explain exactly why userspace want to configure GPIO pins in interrupt mode, when there is no way whatsoever for userspace to handle these IRQs? Maybe I understand something wrong, but explicit

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Drasko DRASKOVIC
On Tue, Oct 9, 2012 at 2:00 PM, Linus Walleij wrote: > On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC > wrote: >> [Me] >>> If I understand correctly the below more or less exports >>> struct irq_chip to userspace, >>> trying to hide it by instead exposing a property of the >>> containing

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Russell King - ARM Linux
On Tue, Oct 09, 2012 at 02:00:34PM +0200, Linus Walleij wrote: > On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC > wrote: > > [Me] > >> If I understand correctly the below more or less exports > >> struct irq_chip to userspace, > >> trying to hide it by instead exposing a property of the > >>

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Linus Walleij
On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC wrote: > [Me] >> If I understand correctly the below more or less exports >> struct irq_chip to userspace, >> trying to hide it by instead exposing a property of the >> containing struct gpio_chip and it worries me. > > No, it should not. You are

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Linus Walleij
On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: [Me] If I understand correctly the below more or less exports struct irq_chip to userspace, trying to hide it by instead exposing a property of the containing struct gpio_chip and it worries me. No, it should

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Russell King - ARM Linux
On Tue, Oct 09, 2012 at 02:00:34PM +0200, Linus Walleij wrote: On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: [Me] If I understand correctly the below more or less exports struct irq_chip to userspace, trying to hide it by instead exposing a property

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-09 Thread Drasko DRASKOVIC
On Tue, Oct 9, 2012 at 2:00 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: [Me] If I understand correctly the below more or less exports struct irq_chip to userspace, trying to hide it by instead exposing a

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-07 Thread Drasko DRASKOVIC
Hi Grant, Thomas, do you see any potential problems with this patch? It adds sysfs interface to change / set-up trigger edge from the kernel (currently not possible). BR, Drasko On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC wrote: > On Fri, Oct 5, 2012 at 2:40 PM, Linus Walleij > wrote:

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-07 Thread Drasko DRASKOVIC
Hi Grant, Thomas, do you see any potential problems with this patch? It adds sysfs interface to change / set-up trigger edge from the kernel (currently not possible). BR, Drasko On Fri, Oct 5, 2012 at 3:16 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: On Fri, Oct 5, 2012 at 2:40 PM,

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
On Fri, Oct 5, 2012 at 2:40 PM, Linus Walleij wrote: > On Fri, Oct 5, 2012 at 2:20 PM, Drasko DRASKOVIC > Why not put the above text into the patch commit blurb? OK, I can add this easily. Makes sense. > If I understand correctly the below more or less exports > struct irq_chip to userspace, >

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Linus Walleij
On Fri, Oct 5, 2012 at 2:20 PM, Drasko DRASKOVIC wrote: > please find a patch that adds IRQ edge set-up mechanism to sysfs that > can be called from the kernel. > > This functionality can be very useful for embedded systems, as it > permits kernel to do GPIO set-up during boot stage.

[PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Sep 17 00:00:00 2001 From: Drasko DRASKOVIC Date: Fri, 5 Oct 2012 11:59:47 +0200 Subject: [PATCH] [PATCH][GPIO] Add IRQ edge setter to gpiolib Signed-off-by: Drasko DRASKOVIC --- Documentation/gpio.txt |3 ++ drivers/gpio/gpiolib.c |

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Hi Mark, thanks. I'll re-send it as a plain text in a separate e-mail. BR, Drasko On Fri, Oct 5, 2012 at 1:50 PM, Mark Brown wrote: > On Fri, Oct 05, 2012 at 01:09:13PM +0200, Drasko DRASKOVIC wrote: >> Looping GPIO maintainers... > > Please follow the patch submission process in >

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Mark Brown
On Fri, Oct 05, 2012 at 01:09:13PM +0200, Drasko DRASKOVIC wrote: > Looping GPIO maintainers... Please follow the patch submission process in Documentation/SubmittingPatches - the main thing here is to not send the patch as an attachment. -- To unsubscribe from this list: send the line

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Looping GPIO maintainers... On Fri, Oct 5, 2012 at 12:45 PM, Drasko DRASKOVIC wrote: > Hi all, > please find a patch that adds IRQ edge set-up mechanism to sysfs that > can be called from the kernel. > > This functionality can be very useful for embedded systems, as it > permits kernel to do

[PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Hi all, please find a patch that adds IRQ edge set-up mechanism to sysfs that can be called from the kernel. This functionality can be very useful for embedded systems, as it permits kernel to do GPIO set-up during boot stage. Configuration which defines pins behavior is often kept in NVRAM, and

[PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Hi all, please find a patch that adds IRQ edge set-up mechanism to sysfs that can be called from the kernel. This functionality can be very useful for embedded systems, as it permits kernel to do GPIO set-up during boot stage. Configuration which defines pins behavior is often kept in NVRAM, and

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Looping GPIO maintainers... On Fri, Oct 5, 2012 at 12:45 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: Hi all, please find a patch that adds IRQ edge set-up mechanism to sysfs that can be called from the kernel. This functionality can be very useful for embedded systems, as it

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Mark Brown
On Fri, Oct 05, 2012 at 01:09:13PM +0200, Drasko DRASKOVIC wrote: Looping GPIO maintainers... Please follow the patch submission process in Documentation/SubmittingPatches - the main thing here is to not send the patch as an attachment. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
Hi Mark, thanks. I'll re-send it as a plain text in a separate e-mail. BR, Drasko On Fri, Oct 5, 2012 at 1:50 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Oct 05, 2012 at 01:09:13PM +0200, Drasko DRASKOVIC wrote: Looping GPIO maintainers... Please follow the patch

[PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
00:00:00 2001 From: Drasko DRASKOVIC drasko.drasko...@gmail.com Date: Fri, 5 Oct 2012 11:59:47 +0200 Subject: [PATCH] [PATCH][GPIO] Add IRQ edge setter to gpiolib Signed-off-by: Drasko DRASKOVIC drasko.drasko...@gmail.com --- Documentation/gpio.txt |3 ++ drivers/gpio/gpiolib.c

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Linus Walleij
On Fri, Oct 5, 2012 at 2:20 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: please find a patch that adds IRQ edge set-up mechanism to sysfs that can be called from the kernel. This functionality can be very useful for embedded systems, as it permits kernel to do GPIO set-up during

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Drasko DRASKOVIC
On Fri, Oct 5, 2012 at 2:40 PM, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 5, 2012 at 2:20 PM, Drasko DRASKOVIC Why not put the above text into the patch commit blurb? OK, I can add this easily. Makes sense. If I understand correctly the below more or less exports struct