Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-09-08 Thread Artem Bityutskiy
On Wed, 2014-08-20 at 10:19 +0100, Colin King wrote: > From: Colin Ian King > > commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") > introduced a dereference on dev (which is not initialized at that > point) when printing a warning message. Re-order disk_capacity check > after

Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-09-08 Thread Artem Bityutskiy
On Thu, 2014-08-21 at 16:12 -0300, Ezequiel Garcia wrote: > On 20 Aug 10:19 AM, Colin King wrote: > > From: Colin Ian King > > > > commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") > > introduced a dereference on dev (which is not initialized at that > > point) when printing a

Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-09-08 Thread Artem Bityutskiy
On Thu, 2014-08-21 at 16:12 -0300, Ezequiel Garcia wrote: On 20 Aug 10:19 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com commit 4df38926f337 (UBI: block: Avoid disk size integer overflow) introduced a dereference on dev (which is not initialized at that point) when

Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-09-08 Thread Artem Bityutskiy
On Wed, 2014-08-20 at 10:19 +0100, Colin King wrote: From: Colin Ian King colin.k...@canonical.com commit 4df38926f337 (UBI: block: Avoid disk size integer overflow) introduced a dereference on dev (which is not initialized at that point) when printing a warning message. Re-order

Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-08-21 Thread Ezequiel Garcia
On 20 Aug 10:19 AM, Colin King wrote: > From: Colin Ian King > > commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") > introduced a dereference on dev (which is not initialized at that > point) when printing a warning message. Re-order disk_capacity check > after the dev is

Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-08-21 Thread Ezequiel Garcia
On 20 Aug 10:19 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com commit 4df38926f337 (UBI: block: Avoid disk size integer overflow) introduced a dereference on dev (which is not initialized at that point) when printing a warning message. Re-order disk_capacity check

[PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-08-20 Thread Colin King
From: Colin Ian King commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") introduced a dereference on dev (which is not initialized at that point) when printing a warning message. Re-order disk_capacity check after the dev is found. Found by cppcheck:

[PATCH][V2] UBI: block: fix dereference on uninitialized dev

2014-08-20 Thread Colin King
From: Colin Ian King colin.k...@canonical.com commit 4df38926f337 (UBI: block: Avoid disk size integer overflow) introduced a dereference on dev (which is not initialized at that point) when printing a warning message. Re-order disk_capacity check after the dev is found. Found by cppcheck: