Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-09 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:14:44PM +, Colin King wrote: > The functions pll_event and dac_event are local to the source and do > not need to be in global scope, so make them static. This looks good to me. Thanks for catching this. You can add: Reviewed-by: Steven Eckhoff

Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-09 Thread Steven Eckhoff
On Mon, Jan 08, 2018 at 11:14:44PM +, Colin King wrote: > The functions pll_event and dac_event are local to the source and do > not need to be in global scope, so make them static. This looks good to me. Thanks for catching this. You can add: Reviewed-by: Steven Eckhoff

[PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-08 Thread Colin King
From: Colin Ian King The functions pll_event and dac_event are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'pll_event' was not declared. Should it be static? symbol 'dac_event' was not declared.

[PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac_event static

2018-01-08 Thread Colin King
From: Colin Ian King The functions pll_event and dac_event are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'pll_event' was not declared. Should it be static? symbol 'dac_event' was not declared. Should it be static?