Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-12 Thread Yu Chen
Hi Doug, On Thu, Apr 12, 2018 at 12:18:44AM -0700, Doug Smythies wrote: > On 2018.04.11 03:31 Yu Chen wrote: > > > From: Chen Yu > > > > There's a use case during test to only print specific round of loops > > if --iterations is specified, for example, with this patch

Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-12 Thread Yu Chen
Hi Doug, On Thu, Apr 12, 2018 at 12:18:44AM -0700, Doug Smythies wrote: > On 2018.04.11 03:31 Yu Chen wrote: > > > From: Chen Yu > > > > There's a use case during test to only print specific round of loops > > if --iterations is specified, for example, with this patch applied: > > > > turbostat

RE: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-12 Thread Doug Smythies
On 2018.04.11 03:31 Yu Chen wrote: > From: Chen Yu > > There's a use case during test to only print specific round of loops > if --iterations is specified, for example, with this patch applied: > > turbostat -i 5 -t 4 > will capture 4 samples with 5 seconds interval. Hi

RE: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-12 Thread Doug Smythies
On 2018.04.11 03:31 Yu Chen wrote: > From: Chen Yu > > There's a use case during test to only print specific round of loops > if --iterations is specified, for example, with this patch applied: > > turbostat -i 5 -t 4 > will capture 4 samples with 5 seconds interval. Hi Yu, This would be a

Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Yu Chen
Hi, On Wed, Apr 11, 2018 at 02:02:02PM +0300, Artem Bityutskiy wrote: > A couple of nitpicks. > > On Wed, 2018-04-11 at 18:30 +0800, Yu Chen wrote: > > @@ -48,6 +48,7 @@ char *proc_stat = "/proc/stat"; > > FILE *outf; > > int *fd_percpu; > > struct timespec interval_ts = {5, 0}; > > +int

Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Yu Chen
Hi, On Wed, Apr 11, 2018 at 02:02:02PM +0300, Artem Bityutskiy wrote: > A couple of nitpicks. > > On Wed, 2018-04-11 at 18:30 +0800, Yu Chen wrote: > > @@ -48,6 +48,7 @@ char *proc_stat = "/proc/stat"; > > FILE *outf; > > int *fd_percpu; > > struct timespec interval_ts = {5, 0}; > > +int

Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Artem Bityutskiy
A couple of nitpicks. On Wed, 2018-04-11 at 18:30 +0800, Yu Chen wrote: > @@ -48,6 +48,7 @@ char *proc_stat = "/proc/stat"; > FILE *outf; > int *fd_percpu; > struct timespec interval_ts = {5, 0}; > +int iterations; OK, out of several choices, you selected "iterations". > unsigned int debug;

Re: [PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Artem Bityutskiy
A couple of nitpicks. On Wed, 2018-04-11 at 18:30 +0800, Yu Chen wrote: > @@ -48,6 +48,7 @@ char *proc_stat = "/proc/stat"; > FILE *outf; > int *fd_percpu; > struct timespec interval_ts = {5, 0}; > +int iterations; OK, out of several choices, you selected "iterations". > unsigned int debug;

[PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Yu Chen
From: Chen Yu There's a use case during test to only print specific round of loops if --iterations is specified, for example, with this patch applied: turbostat -i 5 -t 4 will capture 4 samples with 5 seconds interval. Cc: Len Brown Cc: Rafael J Wysocki

[PATCH][v3] tools/power turbostat: if --max_loop, print for specific time of loops

2018-04-11 Thread Yu Chen
From: Chen Yu There's a use case during test to only print specific round of loops if --iterations is specified, for example, with this patch applied: turbostat -i 5 -t 4 will capture 4 samples with 5 seconds interval. Cc: Len Brown Cc: Rafael J Wysocki Cc: Artem Bityutskiy Cc: