Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread dean gaudet
On Sun, 12 Aug 2007, Linus Torvalds wrote: > On Sun, 12 Aug 2007, Dave Jones wrote: > > > > This does make me wonder, why these weren't caught in -mm ? > > I'm worried that -mm isn't getting a lot of exposure these days. People do > run it, but I wonder how many.. andrew caught it in -mm and r

Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread Linus Torvalds
On Sun, 12 Aug 2007, Dave Jones wrote: > > This does make me wonder, why these weren't caught in -mm ? I'm worried that -mm isn't getting a lot of exposure these days. People do run it, but I wonder how many.. That said, a lot of machines won't ever use MMCFG (especially the old ones - and m

Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread Dave Jones
On Sun, Aug 12, 2007 at 12:15:26PM -0700, Linus Torvalds wrote: > Bugs happen, but (a) they should happen during the merge window, not when > we're in stabilization phase and (b) the percentages here were just not > very good. This does make me wonder, why these weren't caught in -mm ? Andre

Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread Linus Torvalds
On Sun, 12 Aug 2007, Andi Kleen wrote: > > > > Damn you, Andi. > > Thanks for the kind words. Should I be impressed by the fact that 16% of your patches caused bootup problems, when we're really close to a -rc3, and *long* past the point where we want to address regressions rather than cause

Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread Andi Kleen
On Sunday 12 August 2007 11:25, Linus Torvalds wrote: > On Thu, 9 Aug 2007, Andi Kleen wrote: > > Some broken devices have been discovered to require %al/%ax/%eax > > registers for MMIO config space accesses. Modify mmconfig.c to use these > > registers explicitly (rather than modify the global re

Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-12 Thread Linus Torvalds
On Thu, 9 Aug 2007, Andi Kleen wrote: > > Some broken devices have been discovered to require %al/%ax/%eax registers > for MMIO config space accesses. Modify mmconfig.c to use these registers > explicitly (rather than modify the global readb/writeb/etc inlines). > > AK: also changed i386 to a

Re: [patches] [PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-10 Thread Joachim Deguara
I was just queuing up an identical patch ;) We didn't run into a problem yet but we were going to fix this to fit our BKDG documentation. I didn't see the original email, could you point me to it? -Joachim On Thursday 09 August 2007 14:41:28 Andi Kleen wrote: > From: dean gaudet <[EMAIL PROTEC

[PATCH] [1/12] x86: Work around mmio config space quirk on AMD Fam10h

2007-08-09 Thread Andi Kleen
From: dean gaudet <[EMAIL PROTECTED]> Some broken devices have been discovered to require %al/%ax/%eax registers for MMIO config space accesses. Modify mmconfig.c to use these registers explicitly (rather than modify the global readb/writeb/etc inlines). AK: also changed i386 to always use ea