Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-31 Thread Jason Gunthorpe
On Mon, Oct 31, 2016 at 08:51:26AM +, Russell King - ARM Linux wrote: > > -.Ldumpstm: stmfd sp!, {instr, reg, stack, r7, lr} > > + /* Must maintain 8 byte stack alignment */ > > +.Ldumpstm: stmfd sp!, {r3, instr, reg, stack, r7, lr} > > mov stack, r0 > >

Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-31 Thread Jason Gunthorpe
On Mon, Oct 31, 2016 at 08:51:26AM +, Russell King - ARM Linux wrote: > > -.Ldumpstm: stmfd sp!, {instr, reg, stack, r7, lr} > > + /* Must maintain 8 byte stack alignment */ > > +.Ldumpstm: stmfd sp!, {r3, instr, reg, stack, r7, lr} > > mov stack, r0 > >

Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-31 Thread Russell King - ARM Linux
On Tue, Oct 18, 2016 at 11:05:10AM -0600, Jason Gunthorpe wrote: > The dumpstm helper within c_backtrace pushed 5 dwords onto the stack > causing the stack to become unaligned and then calls printk. This > causes memory corruption in the kernel which assumes AAPCS calling > convention. > > Since

Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-31 Thread Russell King - ARM Linux
On Tue, Oct 18, 2016 at 11:05:10AM -0600, Jason Gunthorpe wrote: > The dumpstm helper within c_backtrace pushed 5 dwords onto the stack > causing the stack to become unaligned and then calls printk. This > causes memory corruption in the kernel which assumes AAPCS calling > convention. > > Since

Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-28 Thread Jason Gunthorpe
On Tue, Oct 18, 2016 at 11:05:10AM -0600, Jason Gunthorpe wrote: > The dumpstm helper within c_backtrace pushed 5 dwords onto the stack > causing the stack to become unaligned and then calls printk. This > causes memory corruption in the kernel which assumes AAPCS calling > convention. > > Since

Re: [PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-28 Thread Jason Gunthorpe
On Tue, Oct 18, 2016 at 11:05:10AM -0600, Jason Gunthorpe wrote: > The dumpstm helper within c_backtrace pushed 5 dwords onto the stack > causing the stack to become unaligned and then calls printk. This > causes memory corruption in the kernel which assumes AAPCS calling > convention. > > Since

[PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-18 Thread Jason Gunthorpe
The dumpstm helper within c_backtrace pushed 5 dwords onto the stack causing the stack to become unaligned and then calls printk. This causes memory corruption in the kernel which assumes AAPCS calling convention. Since this bit of asm doesn't use the standard prologue just add another register

[PATCH] [ARM] Fix stack alignment when processing backtraces

2016-10-18 Thread Jason Gunthorpe
The dumpstm helper within c_backtrace pushed 5 dwords onto the stack causing the stack to become unaligned and then calls printk. This causes memory corruption in the kernel which assumes AAPCS calling convention. Since this bit of asm doesn't use the standard prologue just add another register