Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 04:02:19PM +0900, Joonwoo Park wrote: > > [NET]: Fix TX bug VLAN in VLAN > Fix misbehavior of vlan_dev_hard_start_xmit() for recursive encapsulations. > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Applied to net-2.6. Thanks! -- Visit Openswan at http://www.openswa

RE: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Joonwoo Park
2007/11/27, Herbert Xu <[EMAIL PROTECTED]>: > On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote: > > > > Thanks Herbert. > > Well.. I think patch would work propely for AF_PACKET also. > > (I did not insert BUG() macro in my patch) > > How do you think? > > Are you sure? I thought you n

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Herbert Xu
On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote: > > Thanks Herbert. > Well.. I think patch would work propely for AF_PACKET also. > (I did not insert BUG() macro in my patch) > How do you think? Are you sure? I thought you need to check both in the xmit function. That is, i

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Joonwoo Park
2007/11/26, Herbert Xu <[EMAIL PROTECTED]>: > On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote: > > This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766 > > > > Is it possible? > > BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) && > > !(VLAN_DEV_INFO(dev)->flags & VLAN_FLAG

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Herbert Xu
On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote: > This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766 > > Is it possible? > BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) && !(VLAN_DEV_INFO(dev)->flags > & VLAN_FLAG_REORDER_HDR)) > I'm afraid, queued packet before vcon

[PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-23 Thread Joonwoo Park
This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766 Is it possible? BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) && !(VLAN_DEV_INFO(dev)->flags & VLAN_FLAG_REORDER_HDR)) I'm afraid, queued packet before vconfig set_flag would do that. Thanks. Joonwoo [NET]: Fix TX bug VLAN in V