Re: [PATCH] [V1]power: battery: Generic battery driver using IIO

2012-09-17 Thread Lars-Peter Clausen
On 09/17/2012 05:57 AM, anish singh wrote: > Hello Lars, > > Thanks for the review.All of you comments are valid but > i just have a small question w.r.t one of your comments. > Inline below. > > On Sun, Sep 16, 2012 at 9:11 PM, Lars-Peter Clausen wrote: >> On 09/16/2012 09:14 AM, anish kumar wr

Re: [PATCH] [V1]power: battery: Generic battery driver using IIO

2012-09-16 Thread anish singh
Hello Lars, Thanks for the review.All of you comments are valid but i just have a small question w.r.t one of your comments. Inline below. On Sun, Sep 16, 2012 at 9:11 PM, Lars-Peter Clausen wrote: > On 09/16/2012 09:14 AM, anish kumar wrote: >> From: anish kumar >> >> In last version: >> Addre

Re: [PATCH] [V1]power: battery: Generic battery driver using IIO

2012-09-16 Thread Lars-Peter Clausen
On 09/16/2012 09:14 AM, anish kumar wrote: > From: anish kumar > > In last version: > Addressed concerns raised by lars: > a. made the adc_bat per device. > b. get the IIO channel using hardcoded channel names. > c. Minor issues related to gpio_is_valid and some code >refactoring. > > In thi

[PATCH] [V1]power: battery: Generic battery driver using IIO

2012-09-16 Thread anish kumar
From: anish kumar In last version: Addressed concerns raised by lars: a. made the adc_bat per device. b. get the IIO channel using hardcoded channel names. c. Minor issues related to gpio_is_valid and some code refactoring. In this version: Addressed concerns raised by Anton: a. changed the s