Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>> this is not being

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>> this is not being used and cfg is being

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >>

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >> assignment operator should

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:06 PM, Colin King wrote: > From: Colin Ian King > > The value from a readl is being masked with ITE_REG_CIOCAN_MASK however > this is not being used and cfg is being re-assigned. I believe the > assignment operator should actually be instead the |=

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:06 PM, Colin King wrote: > From: Colin Ian King > > The value from a readl is being masked with ITE_REG_CIOCAN_MASK however > this is not being used and cfg is being re-assigned. I believe the > assignment operator should actually be instead the |= operator. > > Detected by

[PATCH] [media] include/media: fix missing | operator when setting cfg

From: Colin Ian King The value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987

[PATCH] [media] include/media: fix missing | operator when setting cfg

From: Colin Ian King The value from a readl is being masked with ITE_REG_CIOCAN_MASK however this is not being used and cfg is being re-assigned. I believe the assignment operator should actually be instead the |= operator. Detected by CoverityScan, CID#1467987 ("Unused value") Signed-off-by: