RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-24 Thread Chen, Yu C
..@kernel.org; > x...@kernel.org; linux...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for > suspend > > On Fri, Aug 21, 2015 at 07:53:34PM +0800, Chen Yu wrote: > > +struct msr_type { > > +

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-24 Thread Borislav Petkov
On Fri, Aug 21, 2015 at 07:53:34PM +0800, Chen Yu wrote: > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > that, after resuming from S3, CPU is working at a low speed. > After investigation, it is found that, BIOS has modified the value > of THERM_CONTROL register during

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-24 Thread Borislav Petkov
On Fri, Aug 21, 2015 at 07:53:34PM +0800, Chen Yu wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3,

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-24 Thread Chen, Yu C
...@kernel.org; linux...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend On Fri, Aug 21, 2015 at 07:53:34PM +0800, Chen Yu wrote: +struct msr_type { + unsigned int msr_id; + bool msr_saved; + u64 msr_value

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Chen, Yu C
Hi, Pavel, > Plus, I acked V2 when V3 was available. > V3 is to only save/restore THERM_CONTRO msr, so I think I'll do some check based on V2, It is more extensible. Thanks, Best Regards, Yu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Chen, Yu C
Hi Ingo, thanks for your reply, > So I like the general structure of the patch and I like the MSR saving > mechanism it introduces, but it is full of typos and small stylistic > uncleanlinesses which need to be fixed before this patch can be applied. > Please don't ack incomplete patches. >

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Pavel Machek
On Sun 2015-08-23 08:20:33, Ingo Molnar wrote: > > * Pavel Machek wrote: > > > On Fri 2015-08-21 19:53:34, Chen Yu wrote: > > > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > > > that, after resuming from S3, CPU is working at a low speed. > > > After investigation, it

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Ingo Molnar
* Pavel Machek wrote: > On Fri 2015-08-21 19:53:34, Chen Yu wrote: > > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > > that, after resuming from S3, CPU is working at a low speed. > > After investigation, it is found that, BIOS has modified the value > > of

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Ingo Molnar
* Pavel Machek pa...@ucw.cz wrote: On Fri 2015-08-21 19:53:34, Chen Yu wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Pavel Machek
On Sun 2015-08-23 08:20:33, Ingo Molnar wrote: * Pavel Machek pa...@ucw.cz wrote: On Fri 2015-08-21 19:53:34, Chen Yu wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Chen, Yu C
Hi, Pavel, Plus, I acked V2 when V3 was available. V3 is to only save/restore THERM_CONTRO msr, so I think I'll do some check based on V2, It is more extensible. Thanks, Best Regards, Yu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-23 Thread Chen, Yu C
Hi Ingo, thanks for your reply, So I like the general structure of the patch and I like the MSR saving mechanism it introduces, but it is full of typos and small stylistic uncleanlinesses which need to be fixed before this patch can be applied. Please don't ack incomplete patches. Sorry

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-22 Thread Pavel Machek
On Fri 2015-08-21 19:53:34, Chen Yu wrote: > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > that, after resuming from S3, CPU is working at a low speed. > After investigation, it is found that, BIOS has modified the value > of THERM_CONTROL register during S3, changes it

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-22 Thread Pavel Machek
On Fri 2015-08-21 19:53:34, Chen Yu wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Chen, Yu C
l...@kernel.org; x...@kernel.org; linux...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for > suspend > > Hi Chen. > > Is there any issue with saving and restoring MSRs unconditionally? That > would sim

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Nigel Cunningham
Hi Chen. Is there any issue with saving and restoring MSRs unconditionally? That would simplify the patch and make things 'just work'. Regards, Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Chen Yu
A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from 0 to 0x10, while the latter means CPU can only

Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Nigel Cunningham
Hi Chen. Is there any issue with saving and restoring MSRs unconditionally? That would simplify the patch and make things 'just work'. Regards, Nigel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

RE: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Chen, Yu C
; linux...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend Hi Chen. Is there any issue with saving and restoring MSRs unconditionally? That would simplify the patch and make things 'just work'. Saving/restoring

[PATCH] [v2] x86, suspend: Save/restore extra MSR registers for suspend

2015-08-21 Thread Chen Yu
A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from 0 to 0x10, while the latter means CPU can only