Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-14 Thread Joe Perches
On Wed, 2007-11-14 at 11:54 +0100, Thomas Gleixner wrote: > can you please CC the relevant maintainers on patches ? I do try. I also happen to have a series of patches to MAINTAINERS and a scripts/get_maintainer.pl that do exactly that. Maybe a future version might use it. cheers, Joe > >

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-14 Thread Thomas Gleixner
Joe, can you please CC the relevant maintainers on patches ? On Tue, 13 Nov 2007, Joe Perches wrote: > Remove defconfig ptr comparison to 0 > > The memcpy from memory location 0 sure looks odd. The memcpy from 0 is completely bogus. I bet this should have been a memset(, 0, ), which is

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-14 Thread Thomas Gleixner
Joe, can you please CC the relevant maintainers on patches ? On Tue, 13 Nov 2007, Joe Perches wrote: Remove defconfig ptr comparison to 0 The memcpy from memory location 0 sure looks odd. The memcpy from 0 is completely bogus. I bet this should have been a memset(header, 0, ), which is

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-14 Thread Joe Perches
On Wed, 2007-11-14 at 11:54 +0100, Thomas Gleixner wrote: can you please CC the relevant maintainers on patches ? I do try. I also happen to have a series of patches to MAINTAINERS and a scripts/get_maintainer.pl that do exactly that. Maybe a future version might use it. cheers, Joe diff

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-13 Thread Linus Torvalds
On Tue, 13 Nov 2007, Joe Perches wrote: > > Remove defconfig ptr comparison to 0 > > The memcpy from memory location 0 sure looks odd. Btw, this is also very compiler-bug-prone. And sadly, the cast to "(void *)" doesn't help. This could easily be a case where a compiler decides to play

[PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-13 Thread Joe Perches
Remove defconfig ptr comparison to 0 The memcpy from memory location 0 sure looks odd. Remove sparse warning: Using plain integer as NULL pointer Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- diff --git a/include/asm-x86/mach-es7000/mach_mpparse.h

[PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-13 Thread Joe Perches
Remove defconfig ptr comparison to 0 The memcpy from memory location 0 sure looks odd. Remove sparse warning: Using plain integer as NULL pointer Signed-off-by: Joe Perches [EMAIL PROTECTED] --- diff --git a/include/asm-x86/mach-es7000/mach_mpparse.h

Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 - include/asm-x86

2007-11-13 Thread Linus Torvalds
On Tue, 13 Nov 2007, Joe Perches wrote: Remove defconfig ptr comparison to 0 The memcpy from memory location 0 sure looks odd. Btw, this is also very compiler-bug-prone. And sadly, the cast to (void *) doesn't help. This could easily be a case where a compiler decides to play lawyer