Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 05:26:04PM +0100, Johannes Weiner wrote: > > The code in there is irksome - it'd be nice to find some way of > > restructuring it to make it less obscure, and to kill that warning. > > Functionscope or filescope? ;) Oh well... I think the latter. I wil clean it up

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:45:40AM -0800, Andrew Morton wrote: > > On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: > > > fs/block_dev.c: In function `bd_claim_by_kobject': > > > fs/block_dev.c:953: warning: `found' might be used uninitialized in this > > > function > > > > found

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 00:56:08 +0100 Johannes Weiner <[EMAIL PROTECTED]> wrote: > On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: > > fs/block_dev.c: In function `bd_claim_by_kobject': > > fs/block_dev.c:953: warning: `found' might be used uninitialized in this > > function > > found

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 00:56:08 +0100 Johannes Weiner [EMAIL PROTECTED] wrote: On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function found actually _is_

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:45:40AM -0800, Andrew Morton wrote: On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function found actually _is_ used

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 05:26:04PM +0100, Johannes Weiner wrote: The code in there is irksome - it'd be nice to find some way of restructuring it to make it less obscure, and to kill that warning. Functionscope or filescope? ;) Oh well... I think the latter. I wil clean it up and

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-21 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: > fs/block_dev.c: In function `bd_claim_by_kobject': > fs/block_dev.c:953: warning: `found' might be used uninitialized in this > function found actually _is_ used uninitialized if the call to bd_claim() returns anything but 0. Thank

[PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-21 Thread roland
Hello ! the attached patch should fix the following compile warning: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function i`m an absolutely awful programmer , but feel free to comment, ignore or merge.

[PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-21 Thread roland
Hello ! the attached patch should fix the following compile warning: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function i`m an absolutely awful programmer , but feel free to comment, ignore or merge.

Re: [PATCH] - fix compile warning: `found' might be used uninitialized in this function

2007-03-21 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 12:48:05AM +0100, roland wrote: fs/block_dev.c: In function `bd_claim_by_kobject': fs/block_dev.c:953: warning: `found' might be used uninitialized in this function found actually _is_ used uninitialized if the call to bd_claim() returns anything but 0. Thank