Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-02 Thread Rafael J. Wysocki
On Sunday, March 02, 2014 08:53:57 AM Li, Aubrey wrote: > On 2014/3/2 8:39, Rafael J. Wysocki wrote: > > On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: > Do we still want to set this if the check below fails? If so, then why? > >>> > >>> We know \_S5_ is valid. The fault is sleep

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-02 Thread Rafael J. Wysocki
On Sunday, March 02, 2014 08:53:57 AM Li, Aubrey wrote: On 2014/3/2 8:39, Rafael J. Wysocki wrote: On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: Do we still want to set this if the check below fails? If so, then why? We know \_S5_ is valid. The fault is sleep registers, not

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-01 Thread Li, Aubrey
On 2014/3/2 8:39, Rafael J. Wysocki wrote: > On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: Do we still want to set this if the check below fails? If so, then why? >>> >>> We know \_S5_ is valid. The fault is sleep registers, not S5 ACPI object >> >> Hi Rafael, do you still have

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-01 Thread Rafael J. Wysocki
On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: > On 2014/2/28 13:33, Li, Aubrey wrote: > > On 2014/2/27 7:50, Rafael J. Wysocki wrote: > >> On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: > >>> Sleep control and status registers need santity check before ACPI > >>> install

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-01 Thread Rafael J. Wysocki
On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: On 2014/2/28 13:33, Li, Aubrey wrote: On 2014/2/27 7:50, Rafael J. Wysocki wrote: On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: Sleep control and status registers need santity check before ACPI install

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-03-01 Thread Li, Aubrey
On 2014/3/2 8:39, Rafael J. Wysocki wrote: On Saturday, March 01, 2014 06:24:23 AM Li, Aubrey wrote: Do we still want to set this if the check below fails? If so, then why? We know \_S5_ is valid. The fault is sleep registers, not S5 ACPI object Hi Rafael, do you still have any concern?

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-28 Thread Li, Aubrey
On 2014/2/28 13:33, Li, Aubrey wrote: > On 2014/2/27 7:50, Rafael J. Wysocki wrote: >> On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: >>> Sleep control and status registers need santity check before ACPI >>> install acpi_power_off to pm_power_off hook. The checking code in >>>

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-28 Thread Li, Aubrey
On 2014/2/28 13:33, Li, Aubrey wrote: On 2014/2/27 7:50, Rafael J. Wysocki wrote: On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: Sleep control and status registers need santity check before ACPI install acpi_power_off to pm_power_off hook. The checking code in

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-27 Thread Li, Aubrey
On 2014/2/27 7:50, Rafael J. Wysocki wrote: > On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: >> Sleep control and status registers need santity check before ACPI >> install acpi_power_off to pm_power_off hook. The checking code in >> acpi_enter_sleep_state() is too late, we should

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-27 Thread Li, Aubrey
On 2014/2/27 7:50, Rafael J. Wysocki wrote: On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: Sleep control and status registers need santity check before ACPI install acpi_power_off to pm_power_off hook. The checking code in acpi_enter_sleep_state() is too late, we should not

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-26 Thread Rafael J. Wysocki
On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: > Sleep control and status registers need santity check before ACPI > install acpi_power_off to pm_power_off hook. The checking code in > acpi_enter_sleep_state() is too late, we should not allow a not-working > pm_power_off function

Re: [PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-26 Thread Rafael J. Wysocki
On Wednesday, February 26, 2014 10:46:37 AM Li, Aubrey wrote: Sleep control and status registers need santity check before ACPI install acpi_power_off to pm_power_off hook. The checking code in acpi_enter_sleep_state() is too late, we should not allow a not-working pm_power_off function

[PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-25 Thread Li, Aubrey
Sleep control and status registers need santity check before ACPI install acpi_power_off to pm_power_off hook. The checking code in acpi_enter_sleep_state() is too late, we should not allow a not-working pm_power_off function hooked. Signed-off-by: Aubrey Li --- drivers/acpi/sleep.c |7

[PATCH] ACPI/Sleep: pm_power_off need more sanity check to be installed

2014-02-25 Thread Li, Aubrey
Sleep control and status registers need santity check before ACPI install acpi_power_off to pm_power_off hook. The checking code in acpi_enter_sleep_state() is too late, we should not allow a not-working pm_power_off function hooked. Signed-off-by: Aubrey Li aubrey...@intel.com ---