Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

2021-03-24 Thread Xiaofei Tan
Hi Rafael, BTW, there is still one warning left reported by checkpatch.pl in this file. The cause of the warning is that it contains an special character '$'. Does it have any special purpose? If no, i can fix it in the new version, too. thanks. WARNING: CVS style keyword markers, these will

Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

2021-03-24 Thread Xiaofei Tan
Hi Rafael, On 2021/3/24 23:57, Rafael J. Wysocki wrote: On Tue, Mar 23, 2021 at 2:01 PM Xiaofei Tan wrote: Fix some errors and warnings reported by checkpatch.pl, including following five types: Well, they are coding style issues rather than errors. Right, i could change the description.

Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

2021-03-24 Thread Rafael J. Wysocki
On Tue, Mar 23, 2021 at 2:01 PM Xiaofei Tan wrote: > > Fix some errors and warnings reported by checkpatch.pl, including > following five types: Well, they are coding style issues rather than errors. > ERROR: "foo * bar" should be "foo *bar" > ERROR: code indent should use tabs where possible >

[PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

2021-03-23 Thread Xiaofei Tan
Fix some errors and warnings reported by checkpatch.pl, including following five types: ERROR: "foo * bar" should be "foo *bar" ERROR: code indent should use tabs where possible WARNING: Block comments use a trailing */ on a separate line WARNING: braces {} are not necessary for single statement bl