Re: [PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-17 Thread Alexey Starikovskiy 

Marton,
Could you please attach these patches to bug report? It is easier to track them 
there.

Thanks,
Alex.

Németh Márton wrote:

From: Márton Németh <[EMAIL PROTECTED]>

Add leading zeros to pr_debug() calls. For example if x=0x0a, the format
"0x%2x" will result the string "0x a", the format "0x%2.2x" will result "0x0a".

Signed-off-by: Márton Németh <[EMAIL PROTECTED]>
---
--- linux-2.6.24-rc8/drivers/acpi/ec.c.orig 2008-01-16 07:25:33.0 
+0100
+++ linux-2.6.24-rc8/drivers/acpi/ec.c  2008-01-17 07:15:10.0 +0100
@@ -138,26 +138,26 @@ static struct acpi_ec {
 static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
 {
u8 x = inb(ec->command_addr);
-   pr_debug(PREFIX "---> status = 0x%2x\n", x);
+   pr_debug(PREFIX "---> status = 0x%2.2x\n", x);
return x;
 }

 static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
 {
u8 x = inb(ec->data_addr);
-   pr_debug(PREFIX "---> data = 0x%2x\n", x);
+   pr_debug(PREFIX "---> data = 0x%2.2x\n", x);
return inb(ec->data_addr);
 }

 static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
 {
-   pr_debug(PREFIX "<--- command = 0x%2x\n", command);
+   pr_debug(PREFIX "<--- command = 0x%2.2x\n", command);
outb(command, ec->command_addr);
 }

 static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
 {
-   pr_debug(PREFIX "<--- data = 0x%2x\n", data);
+   pr_debug(PREFIX "<--- data = 0x%2.2x\n", data);
outb(data, ec->data_addr);
 }



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-17 Thread Alexey Starikovskiy 

Marton,
Could you please attach these patches to bug report? It is easier to track them 
there.

Thanks,
Alex.

Németh Márton wrote:

From: Márton Németh [EMAIL PROTECTED]

Add leading zeros to pr_debug() calls. For example if x=0x0a, the format
0x%2x will result the string 0x a, the format 0x%2.2x will result 0x0a.

Signed-off-by: Márton Németh [EMAIL PROTECTED]
---
--- linux-2.6.24-rc8/drivers/acpi/ec.c.orig 2008-01-16 07:25:33.0 
+0100
+++ linux-2.6.24-rc8/drivers/acpi/ec.c  2008-01-17 07:15:10.0 +0100
@@ -138,26 +138,26 @@ static struct acpi_ec {
 static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
 {
u8 x = inb(ec-command_addr);
-   pr_debug(PREFIX --- status = 0x%2x\n, x);
+   pr_debug(PREFIX --- status = 0x%2.2x\n, x);
return x;
 }

 static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
 {
u8 x = inb(ec-data_addr);
-   pr_debug(PREFIX --- data = 0x%2x\n, x);
+   pr_debug(PREFIX --- data = 0x%2.2x\n, x);
return inb(ec-data_addr);
 }

 static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
 {
-   pr_debug(PREFIX --- command = 0x%2x\n, command);
+   pr_debug(PREFIX --- command = 0x%2.2x\n, command);
outb(command, ec-command_addr);
 }

 static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
 {
-   pr_debug(PREFIX --- data = 0x%2x\n, data);
+   pr_debug(PREFIX --- data = 0x%2.2x\n, data);
outb(data, ec-data_addr);
 }



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-16 Thread Németh Márton 
From: Márton Németh <[EMAIL PROTECTED]>

Add leading zeros to pr_debug() calls. For example if x=0x0a, the format
"0x%2x" will result the string "0x a", the format "0x%2.2x" will result "0x0a".

Signed-off-by: Márton Németh <[EMAIL PROTECTED]>
---
--- linux-2.6.24-rc8/drivers/acpi/ec.c.orig 2008-01-16 07:25:33.0 
+0100
+++ linux-2.6.24-rc8/drivers/acpi/ec.c  2008-01-17 07:15:10.0 +0100
@@ -138,26 +138,26 @@ static struct acpi_ec {
 static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
 {
u8 x = inb(ec->command_addr);
-   pr_debug(PREFIX "---> status = 0x%2x\n", x);
+   pr_debug(PREFIX "---> status = 0x%2.2x\n", x);
return x;
 }

 static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
 {
u8 x = inb(ec->data_addr);
-   pr_debug(PREFIX "---> data = 0x%2x\n", x);
+   pr_debug(PREFIX "---> data = 0x%2.2x\n", x);
return inb(ec->data_addr);
 }

 static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
 {
-   pr_debug(PREFIX "<--- command = 0x%2x\n", command);
+   pr_debug(PREFIX "<--- command = 0x%2.2x\n", command);
outb(command, ec->command_addr);
 }

 static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
 {
-   pr_debug(PREFIX "<--- data = 0x%2x\n", data);
+   pr_debug(PREFIX "<--- data = 0x%2.2x\n", data);
outb(data, ec->data_addr);
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-16 Thread Németh Márton 
From: Márton Németh [EMAIL PROTECTED]

Add leading zeros to pr_debug() calls. For example if x=0x0a, the format
0x%2x will result the string 0x a, the format 0x%2.2x will result 0x0a.

Signed-off-by: Márton Németh [EMAIL PROTECTED]
---
--- linux-2.6.24-rc8/drivers/acpi/ec.c.orig 2008-01-16 07:25:33.0 
+0100
+++ linux-2.6.24-rc8/drivers/acpi/ec.c  2008-01-17 07:15:10.0 +0100
@@ -138,26 +138,26 @@ static struct acpi_ec {
 static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
 {
u8 x = inb(ec-command_addr);
-   pr_debug(PREFIX --- status = 0x%2x\n, x);
+   pr_debug(PREFIX --- status = 0x%2.2x\n, x);
return x;
 }

 static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
 {
u8 x = inb(ec-data_addr);
-   pr_debug(PREFIX --- data = 0x%2x\n, x);
+   pr_debug(PREFIX --- data = 0x%2.2x\n, x);
return inb(ec-data_addr);
 }

 static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
 {
-   pr_debug(PREFIX --- command = 0x%2x\n, command);
+   pr_debug(PREFIX --- command = 0x%2.2x\n, command);
outb(command, ec-command_addr);
 }

 static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
 {
-   pr_debug(PREFIX --- data = 0x%2x\n, data);
+   pr_debug(PREFIX --- data = 0x%2.2x\n, data);
outb(data, ec-data_addr);
 }

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/