Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-07 Thread Hans de Goede
Hi, On 07-11-18 13:22, Rafael J. Wysocki wrote: On Fri, Nov 2, 2018 at 12:07 PM Arnd Bergmann wrote: We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': intel_pmic_xpower.c:(.tex

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-07 Thread Rafael J. Wysocki
On Fri, Nov 2, 2018 at 12:07 PM Arnd Bergmann wrote: > > We still get a link failure with IOSF_MBI=m when the xpower driver > is built-in: > > drivers/acpi/pmic/intel_pmic_xpower.o: In function > `intel_xpower_pmic_update_power': > intel_pmic_xpower.c:(.text+0x4f2): undefined reference to > `ios

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Fri, Nov 02, 2018 at 11:07:34PM +0100, Arnd Bergmann wrote: >> On 11/2/18, Andy Shevchenko wrote: >> > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > >> >> - depends on MFD_AXP20X_I2C && IOSF_MBI >> >> + depends on MFD_AXP20X_I2C && IOSF_M

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-05 Thread Andy Shevchenko
On Fri, Nov 02, 2018 at 11:07:34PM +0100, Arnd Bergmann wrote: > On 11/2/18, Andy Shevchenko wrote: > > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > >> - depends on MFD_AXP20X_I2C && IOSF_MBI > >> + depends on MFD_AXP20X_I2C && IOSF_MBI=y > > > > To me sounds like > > > > se

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Arnd Bergmann wrote: > On 11/2/18, Andy Shevchenko wrote: >> On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: >>> We still get a link failure with IOSF_MBI=m when the xpower driver >>> is built-in: >>> >>> drivers/acpi/pmic/intel_pmic_xpower.o: In function >>> `intel_xpo

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Andy Shevchenko wrote: > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: >> We still get a link failure with IOSF_MBI=m when the xpower driver >> is built-in: >> >> drivers/acpi/pmic/intel_pmic_xpower.o: In function >> `intel_xpower_pmic_update_power': >> intel_pmic_xpow

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote: > We still get a link failure with IOSF_MBI=m when the xpower driver > is built-in: > > drivers/acpi/pmic/intel_pmic_xpower.o: In function > `intel_xpower_pmic_update_power': > intel_pmic_xpower.c:(.text+0x4f2): undefined reference to

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 02, 2018 at 12:09:34PM +0100, Hans de Goede wrote: > Hi, > > On 02-11-18 12:06, Arnd Bergmann wrote: > > We still get a link failure with IOSF_MBI=m when the xpower driver > > is built-in: > > > > drivers/acpi/pmic/intel_pmic_xpower.o: In function > > `intel_xpower_pmic_update_power'

Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Hans de Goede
Hi, On 02-11-18 12:06, Arnd Bergmann wrote: We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': intel_pmic_xpower.c:(.text+0x4f2): undefined reference to `iosf_mbi_block_punit_i2c_

[PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

2018-11-02 Thread Arnd Bergmann
We still get a link failure with IOSF_MBI=m when the xpower driver is built-in: drivers/acpi/pmic/intel_pmic_xpower.o: In function `intel_xpower_pmic_update_power': intel_pmic_xpower.c:(.text+0x4f2): undefined reference to `iosf_mbi_block_punit_i2c_access' intel_pmic_xpower.c:(.text+0x5e2): unde