Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-20 Thread Pavel Machek
Hi! > > > Anyways this ultimately is Rafael's call. If Rafael is ok with this > > > patch then I would like to see Pavel's comment addressed and otherwise > > > it is fine with me. > > > > > If we can get to an agreement on this I'll send a v2 without division. > > > > Note that we will still of

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-19 Thread João Paulo Rechi Vita
On Sun, Nov 11, 2018 at 4:22 AM Pavel Machek wrote: > > On Sun 2018-11-11 12:57:12, Hans de Goede wrote: > > Hi, > > > > On 11/7/18 5:53 AM, Daniel Drake wrote: > > >On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > > >>Plus, I don't think "100% charge" is right test for "battery full". At > >

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Pavel Machek
On Sun 2018-11-11 12:57:12, Hans de Goede wrote: > Hi, > > On 11/7/18 5:53 AM, Daniel Drake wrote: > >On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > >>Plus, I don't think "100% charge" is right test for "battery full". At > >>least on thinkpads, there's configuration option, and it is commo

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Hans de Goede
Hi, On 11/7/18 5:53 AM, Daniel Drake wrote: On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: Plus, I don't think "100% charge" is right test for "battery full". At least on thinkpads, there's configuration option, and it is common _not_ to charge batterry above 95% or so (to increase its lif

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-11 Thread Pavel Machek
Hi! > > >* was plugged in and the device thus did not start a new charge > > > cycle. > > >*/ > > > if ((battery_ac_is_broken || power_supply_is_system_supplied()) && > > > - battery->rate_now == 0) > > > + battery->rate_now == 0) { > > > + if (ba

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread Daniel Drake
On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > Plus, I don't think "100% charge" is right test for "battery full". At > least on thinkpads, there's configuration option, and it is common > _not_ to charge batterry above 95% or so (to increase its lifetime). Hans also touched on this area in

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > > On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines when AC was connected but the battery was > > not charging. But now on these machin

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
Hello Hans, thanks for your quick response, On Sat, Nov 3, 2018 at 4:28 AM Hans de Goede wrote: > > Hi, > > On 03-11-18 07:57, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines when AC was connected but the battery

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-05 Thread Pavel Machek
On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote: > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > "Discharging" on some machines when AC was connected but the battery was > not charging. But now on these machines the battery status is reported > as "Not charging" even whe

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-03 Thread Hans de Goede
Hi, On 03-11-18 07:57, João Paulo Rechi Vita wrote: Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting "Discharging" on some machines when AC was connected but the battery was not charging. But now on these machines the battery status is reported as "Not charging" even when the batt

[PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-02 Thread João Paulo Rechi Vita
Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting "Discharging" on some machines when AC was connected but the battery was not charging. But now on these machines the battery status is reported as "Not charging" even when the battery is fully charged. This commit takes the battery ca