Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Takashi Iwai
On Tue, 30 May 2017 10:56:39 +0200, Julia Lawall wrote: > > > > On Tue, 30 May 2017, Takashi Iwai wrote: > > > On Sat, 27 May 2017 16:46:15 +0200, > > Bhumika Goyal wrote: > > > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > > argument to the function

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Takashi Iwai
On Tue, 30 May 2017 10:56:39 +0200, Julia Lawall wrote: > > > > On Tue, 30 May 2017, Takashi Iwai wrote: > > > On Sat, 27 May 2017 16:46:15 +0200, > > Bhumika Goyal wrote: > > > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > > argument to the function

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Bhumika Goyal
On Tue, May 30, 2017 at 2:26 PM, Julia Lawall wrote: > > > On Tue, 30 May 2017, Takashi Iwai wrote: > >> On Sat, 27 May 2017 16:46:15 +0200, >> Bhumika Goyal wrote: >> > >> > Declare snd_kcontrol_new structures as const as they are only passed an >> > argument to the

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Bhumika Goyal
On Tue, May 30, 2017 at 2:26 PM, Julia Lawall wrote: > > > On Tue, 30 May 2017, Takashi Iwai wrote: > >> On Sat, 27 May 2017 16:46:15 +0200, >> Bhumika Goyal wrote: >> > >> > Declare snd_kcontrol_new structures as const as they are only passed an >> > argument to the function snd_ctl_new1. This

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Julia Lawall
On Tue, 30 May 2017, Takashi Iwai wrote: > On Sat, 27 May 2017 16:46:15 +0200, > Bhumika Goyal wrote: > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > argument to the function snd_ctl_new1. This argument is of type const, > > so snd_kcontrol_new structures

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Julia Lawall
On Tue, 30 May 2017, Takashi Iwai wrote: > On Sat, 27 May 2017 16:46:15 +0200, > Bhumika Goyal wrote: > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > argument to the function snd_ctl_new1. This argument is of type const, > > so snd_kcontrol_new structures

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Bhumika Goyal
On Tue, May 30, 2017 at 2:24 PM, Takashi Iwai wrote: > On Sat, 27 May 2017 16:46:15 +0200, > Bhumika Goyal wrote: >> >> Declare snd_kcontrol_new structures as const as they are only passed an >> argument to the function snd_ctl_new1. This argument is of type const, >> so

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Bhumika Goyal
On Tue, May 30, 2017 at 2:24 PM, Takashi Iwai wrote: > On Sat, 27 May 2017 16:46:15 +0200, > Bhumika Goyal wrote: >> >> Declare snd_kcontrol_new structures as const as they are only passed an >> argument to the function snd_ctl_new1. This argument is of type const, >> so snd_kcontrol_new

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Takashi Iwai
On Sat, 27 May 2017 16:46:15 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-30 Thread Takashi Iwai
On Sat, 27 May 2017 16:46:15 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-29 Thread Mark Brown
On Sat, May 27, 2017 at 08:16:15PM +0530, Bhumika Goyal wrote: > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-29 Thread Mark Brown
On Sat, May 27, 2017 at 08:16:15PM +0530, Bhumika Goyal wrote: > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

[PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-27 Thread Bhumika Goyal
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@

[PATCH] ALSA: declare snd_kcontrol_new structures as const

2017-05-27 Thread Bhumika Goyal
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@