Re: [PATCH] ALSA: intel8x0: fix a redundant check bug

2018-10-09 Thread Takashi Iwai
On Tue, 09 Oct 2018 16:35:52 +0200, Wenwen Wang wrote: > > In snd_intel8x0_codec_semaphore(), the parameter 'codec' is firstly > checked to see whether it is greater than 2. If yes, an error code EIO is > returned. Otherwise, 'chip->in_sdin_init' is further checked. If > 'chip->in_sdin_init' is no

[PATCH] ALSA: intel8x0: fix a redundant check bug

2018-10-09 Thread Wenwen Wang
In snd_intel8x0_codec_semaphore(), the parameter 'codec' is firstly checked to see whether it is greater than 2. If yes, an error code EIO is returned. Otherwise, 'chip->in_sdin_init' is further checked. If 'chip->in_sdin_init' is not zero, 'codec' is updated immediately with 'chip->codec_isr_bits'