Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Bhumika Goyal
On Mon, May 22, 2017 at 11:59 AM, Takashi Iwai wrote: > On Mon, 22 May 2017 08:20:45 +0200, > Julia Lawall wrote: >> >> >> >> On Mon, 22 May 2017, Bhumika Goyal wrote: >> >> > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: >> > > On Wed, 17 May 2017 14:33:45

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Bhumika Goyal
On Mon, May 22, 2017 at 11:59 AM, Takashi Iwai wrote: > On Mon, 22 May 2017 08:20:45 +0200, > Julia Lawall wrote: >> >> >> >> On Mon, 22 May 2017, Bhumika Goyal wrote: >> >> > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: >> > > On Wed, 17 May 2017 14:33:45 +0200, >> > > Bhumika Goyal

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Takashi Iwai
On Mon, 22 May 2017 08:20:45 +0200, Julia Lawall wrote: > > > > On Mon, 22 May 2017, Bhumika Goyal wrote: > > > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > > > On Wed, 17 May 2017 14:33:45 +0200, > > > Bhumika Goyal wrote: > > >> > > >> On Wed, May 17, 2017 at 5:50

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Takashi Iwai
On Mon, 22 May 2017 08:20:45 +0200, Julia Lawall wrote: > > > > On Mon, 22 May 2017, Bhumika Goyal wrote: > > > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > > > On Wed, 17 May 2017 14:33:45 +0200, > > > Bhumika Goyal wrote: > > >> > > >> On Wed, May 17, 2017 at 5:50 PM, Takashi

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Julia Lawall
On Mon, 22 May 2017, Bhumika Goyal wrote: > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 14:33:45 +0200, > > Bhumika Goyal wrote: > >> > >> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > >> > On Wed, 17 May 2017 13:38:56

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-22 Thread Julia Lawall
On Mon, 22 May 2017, Bhumika Goyal wrote: > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 14:33:45 +0200, > > Bhumika Goyal wrote: > >> > >> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > >> > On Wed, 17 May 2017 13:38:56 +0200, > >> > Bhumika Goyal

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-21 Thread Bhumika Goyal
On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > On Wed, 17 May 2017 14:33:45 +0200, > Bhumika Goyal wrote: >> >> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: >> > On Wed, 17 May 2017 13:38:56 +0200, >> > Bhumika Goyal wrote: >> >> >> >> Declare

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-21 Thread Bhumika Goyal
On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > On Wed, 17 May 2017 14:33:45 +0200, > Bhumika Goyal wrote: >> >> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: >> > On Wed, 17 May 2017 13:38:56 +0200, >> > Bhumika Goyal wrote: >> >> >> >> Declare snd_kcontrol_new structures as

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-21 Thread Takashi Iwai
On Wed, 17 May 2017 14:33:45 +0200, Bhumika Goyal wrote: > > On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 13:38:56 +0200, > > Bhumika Goyal wrote: > >> > >> Declare snd_kcontrol_new structures as const as they are only passed an > >> argument to the

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-21 Thread Takashi Iwai
On Wed, 17 May 2017 14:33:45 +0200, Bhumika Goyal wrote: > > On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 13:38:56 +0200, > > Bhumika Goyal wrote: > >> > >> Declare snd_kcontrol_new structures as const as they are only passed an > >> argument to the function

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Bhumika Goyal
On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > On Wed, 17 May 2017 13:38:56 +0200, > Bhumika Goyal wrote: >> >> Declare snd_kcontrol_new structures as const as they are only passed an >> argument to the function snd_ctl_new1. This argument is of type const, >> so

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Bhumika Goyal
On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > On Wed, 17 May 2017 13:38:56 +0200, > Bhumika Goyal wrote: >> >> Declare snd_kcontrol_new structures as const as they are only passed an >> argument to the function snd_ctl_new1. This argument is of type const, >> so snd_kcontrol_new

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Takashi Iwai
On Wed, 17 May 2017 13:38:56 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Takashi Iwai
On Wed, 17 May 2017 13:38:56 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using

[PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Bhumika Goyal
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@

[PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

2017-05-17 Thread Bhumika Goyal
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@