Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-10-04 Thread Keerthy
ot-on;
+};
+
+ldoln_reg: ldoln {
+/* VDDA_1V8_PLL */
+regulator-name = "ldoln";
+regulator-min-microvolt = <180>;
+regulator-max-microvolt = <180>;
+regulator-always-on;
+regulator-boot-on;
+};
+
+ldousb_reg: ldousb {
+/* VDDA_3V_USB: VDDA_USBHS33 */
+regulator-name = "ldousb";
+regulator-min-microvolt = <330>;
+regulator-max-microvolt = <330>;
+regulator-boot-on;
+};
+

Nit: Extra blank line not needed.


+};
+};
+};
   };

Nit: You have an extra level on indentation not needed.


{


Acked-by: Nishanth Menon 

Beside the two minors nits, the patch looks good to me.

Since, you've been waiting for some time for it, I fixed it myself and pulled 
it.
I even fixed the changelog... Lucky you :-)

You can check the updated version below.

Sorry for the delay.

Thanks,
Benoit

---
 From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001
From: Keerthy 
Date: Mon, 26 Aug 2013 11:06:51 +0530
Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

Add DT nodes for TPS659038 PMIC on DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:
- Documentation/devicetree/bindings/mfd/palmas.txt
- Documentation/devicetree/bindings/regulator/palmas-pmic.txt

Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy 
Acked-by: Nishanth Menon 
[bcous...@baylibre.com: Fix indentation and changelog]
Signed-off-by: Benoit Cousson 
---
  arch/arm/boot/dts/dra7-evm.dts | 112 +
  1 file changed, 112 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index ca5dab2..fbbe406 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,118 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 85>;
+   regulator-max-microvolt = <125>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 85>;
+   regulator-max-microvolt = <115>;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = <85>;
+   regulator-max-microvolt = <1250>;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = "smps7";
+   regulator-min-microvolt = <85>;
+   regulator-max-microvolt = <103>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 85>;
+   regulator-max-microvolt = <125>;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-10-04 Thread Keerthy
-on;
+regulator-boot-on;
+};
+
+ldousb_reg: ldousb {
+/* VDDA_3V_USB: VDDA_USBHS33 */
+regulator-name = ldousb;
+regulator-min-microvolt = 330;
+regulator-max-microvolt = 330;
+regulator-boot-on;
+};
+

Nit: Extra blank line not needed.


+};
+};
+};
   };

Nit: You have an extra level on indentation not needed.


   i2c2 {


Acked-by: Nishanth Menon n...@ti.com

Beside the two minors nits, the patch looks good to me.

Since, you've been waiting for some time for it, I fixed it myself and pulled 
it.
I even fixed the changelog... Lucky you :-)

You can check the updated version below.

Sorry for the delay.

Thanks,
Benoit

---
 From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001
From: Keerthy j-keer...@ti.com
Date: Mon, 26 Aug 2013 11:06:51 +0530
Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

Add DT nodes for TPS659038 PMIC on DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:
- Documentation/devicetree/bindings/mfd/palmas.txt
- Documentation/devicetree/bindings/regulator/palmas-pmic.txt

Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy j-keer...@ti.com
Acked-by: Nishanth Menon n...@ti.com
[bcous...@baylibre.com: Fix indentation and changelog]
Signed-off-by: Benoit Cousson bcous...@baylibre.com
---
  arch/arm/boot/dts/dra7-evm.dts | 112 +
  1 file changed, 112 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index ca5dab2..fbbe406 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,118 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 125;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 115;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 85;
+   regulator-max-microvolt = 1250;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = smps7;
+   regulator-min-microvolt = 85;
+   regulator-max-microvolt = 103;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 125;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-10-03 Thread Benoit Cousson
egulator-boot-on;
>>> +};
>>> +
>>> +ldo2_reg: ldo2 {
>>> +/* VDD_RTCIO */
>>> +/* LDO2 -> VDDSHV5, LDO2 also goes to 
>>> CAN_PHY_3V3 */
>>> +regulator-name = "ldo2";
>>> +regulator-min-microvolt = <330>;
>>> +regulator-max-microvolt = <330>;
>>> +regulator-boot-on;
>>> +};
>>> +
>>> +ldo3_reg: ldo3 {
>>> +/* VDDA_1V8_PHY */
>>> +regulator-name = "ldo3";
>>> +regulator-min-microvolt = <180>;
>>> +regulator-max-microvolt = <180>;
>>> +regulator-boot-on;
>>> +};
>>> +
>>> +ldo9_reg: ldo9 {
>>> +/* VDD_RTC */
>>> +regulator-name = "ldo9";
>>> +regulator-min-microvolt = <105>;
>>> +regulator-max-microvolt = <105>;
>>> +regulator-boot-on;
>>> +};
>>> +
>>> +    ldoln_reg: ldoln {
>>> +    /* VDDA_1V8_PLL */
>>> +regulator-name = "ldoln";
>>> +regulator-min-microvolt = <180>;
>>> +regulator-max-microvolt = <180>;
>>> +regulator-always-on;
>>> +regulator-boot-on;
>>> +};
>>> +
>>> +ldousb_reg: ldousb {
>>> +/* VDDA_3V_USB: VDDA_USBHS33 */
>>> +regulator-name = "ldousb";
>>> +regulator-min-microvolt = <330>;
>>> +regulator-max-microvolt = <330>;
>>> +regulator-boot-on;
>>> +};
>>> +

Nit: Extra blank line not needed.

>>> +};
>>> +};
>>> +};
>>>   };

Nit: You have an extra level on indentation not needed.

>>>{
>>>
>> Acked-by: Nishanth Menon 

Beside the two minors nits, the patch looks good to me.

Since, you've been waiting for some time for it, I fixed it myself and pulled 
it.
I even fixed the changelog... Lucky you :-)

You can check the updated version below.

Sorry for the delay.

Thanks,
Benoit

---
>From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001
From: Keerthy 
Date: Mon, 26 Aug 2013 11:06:51 +0530
Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

Add DT nodes for TPS659038 PMIC on DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:
- Documentation/devicetree/bindings/mfd/palmas.txt
- Documentation/devicetree/bindings/regulator/palmas-pmic.txt

Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy 
Acked-by: Nishanth Menon 
[bcous...@baylibre.com: Fix indentation and changelog]
Signed-off-by: Benoit Cousson 
---
 arch/arm/boot/dts/dra7-evm.dts | 112 +
 1 file changed, 112 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index ca5dab2..fbbe406 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,118 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 85>;
+   regulator-max-microvolt = <125>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+  

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-10-03 Thread Benoit Cousson
-always-on;
 +regulator-boot-on;
 +};
 +
 +ldousb_reg: ldousb {
 +/* VDDA_3V_USB: VDDA_USBHS33 */
 +regulator-name = ldousb;
 +regulator-min-microvolt = 330;
 +regulator-max-microvolt = 330;
 +regulator-boot-on;
 +};
 +

Nit: Extra blank line not needed.

 +};
 +};
 +};
   };

Nit: You have an extra level on indentation not needed.

   i2c2 {

 Acked-by: Nishanth Menon n...@ti.com

Beside the two minors nits, the patch looks good to me.

Since, you've been waiting for some time for it, I fixed it myself and pulled 
it.
I even fixed the changelog... Lucky you :-)

You can check the updated version below.

Sorry for the delay.

Thanks,
Benoit

---
From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001
From: Keerthy j-keer...@ti.com
Date: Mon, 26 Aug 2013 11:06:51 +0530
Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

Add DT nodes for TPS659038 PMIC on DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:
- Documentation/devicetree/bindings/mfd/palmas.txt
- Documentation/devicetree/bindings/regulator/palmas-pmic.txt

Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy j-keer...@ti.com
Acked-by: Nishanth Menon n...@ti.com
[bcous...@baylibre.com: Fix indentation and changelog]
Signed-off-by: Benoit Cousson bcous...@baylibre.com
---
 arch/arm/boot/dts/dra7-evm.dts | 112 +
 1 file changed, 112 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index ca5dab2..fbbe406 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,118 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 125;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 115;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 85;
+   regulator-max-microvolt = 1250;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = smps7;
+   regulator-min-microvolt = 85;
+   regulator-max-microvolt = 103;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  85;
+   regulator-max-microvolt = 125;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-10 Thread Keerthy

On Tuesday 10 September 2013 12:51 AM, Nishanth Menon wrote:

On 08/26/2013 12:36 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy 
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<115>;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<1250>;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = "smps7";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<103>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = "smps9";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT --> SDIO  */
+   regulator-name = "ldo1";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<330>;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 -> VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-10 Thread Keerthy

On Tuesday 10 September 2013 12:51 AM, Nishanth Menon wrote:

On 08/26/2013 12:36 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy j-keer...@ti.com
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
115;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
1250;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = smps7;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
103;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT -- SDIO  */
+   regulator-name = ldo1;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
330;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 - VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+   

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-09 Thread Nishanth Menon
On 08/26/2013 12:36 AM, Keerthy wrote:
> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
> 
> It is based on top of:
> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
> 
> Documentation:Documentation/devicetree/bindings/mfd/palmas.txt
>   Documentation/devicetree/bindings/regulator/palmas-pmic.txt 
> 
> 
> Boot Tested on DRA7 d1 Board.
> 
> Signed-off-by: Keerthy 
> ---
>  arch/arm/boot/dts/dra7-evm.dts |  118 
> 
>  1 file changed, 118 insertions(+)
> 
> Index: linux/arch/arm/boot/dts/dra7-evm.dts
> ===
> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 
> +0530
> +++ linux/arch/arm/boot/dts/dra7-evm.dts  2013-08-26 10:38:44.995414695 
> +0530
> @@ -93,6 +93,119 @@
>   pinctrl-names = "default";
>   pinctrl-0 = <_pins>;
>   clock-frequency = <40>;
> +
> + tps659038: tps659038@58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps123_reg: smps123 {
> + /* VDD_MPU */
> + regulator-name = "smps123";
> + regulator-min-microvolt = < 
> 85>;
> + regulator-max-microvolt = 
> <125>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 
> 85>;
> + regulator-max-microvolt = 
> <115>;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU - over VDD_SMPS6 */
> + regulator-name = "smps6";
> + regulator-min-microvolt = 
> <85>;
> + regulator-max-microvolt = 
> <1250>;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* CORE_VDD */
> + regulator-name = "smps7";
> + regulator-min-microvolt = 
> <85>;
> + regulator-max-microvolt = 
> <103>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVAHD */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 
> 85>;
> + regulator-max-microvolt = 
> <125>;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* VDDS1V8 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = 
> <180>;
> + regulator-max-microvolt = 
> <180>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + /* LDO1_OUT --> SDIO  */
> + regulator-name = "ldo1";
> + regulator-min-microvolt = 
> <180>;
> + regulator-max-microvolt = 
> <330>;
> + regulator-boot-on;
> + };
> +
> + ldo2_reg: ldo2 {
> + /* VDD_RTCIO */
> + /* LDO2 -> VDDSHV5, LDO2 also 
> goes to 

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-09 Thread Nishanth Menon
On 08/26/2013 12:36 AM, Keerthy wrote:
 The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
 
 It is based on top of:
 http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
 
 Documentation:Documentation/devicetree/bindings/mfd/palmas.txt
   Documentation/devicetree/bindings/regulator/palmas-pmic.txt 
 
 
 Boot Tested on DRA7 d1 Board.
 
 Signed-off-by: Keerthy j-keer...@ti.com
 ---
  arch/arm/boot/dts/dra7-evm.dts |  118 
 
  1 file changed, 118 insertions(+)
 
 Index: linux/arch/arm/boot/dts/dra7-evm.dts
 ===
 --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 09:57:52.496173554 
 +0530
 +++ linux/arch/arm/boot/dts/dra7-evm.dts  2013-08-26 10:38:44.995414695 
 +0530
 @@ -93,6 +93,119 @@
   pinctrl-names = default;
   pinctrl-0 = i2c1_pins;
   clock-frequency = 40;
 +
 + tps659038: tps659038@58 {
 + compatible = ti,tps659038;
 + reg = 0x58;
 +
 + tps659038_pmic {
 + compatible = ti,tps659038-pmic;
 +
 + regulators {
 + smps123_reg: smps123 {
 + /* VDD_MPU */
 + regulator-name = smps123;
 + regulator-min-microvolt =  
 85;
 + regulator-max-microvolt = 
 125;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps45_reg: smps45 {
 + /* VDD_DSPEVE */
 + regulator-name = smps45;
 + regulator-min-microvolt =  
 85;
 + regulator-max-microvolt = 
 115;
 + regulator-boot-on;
 + };
 +
 + smps6_reg: smps6 {
 + /* VDD_GPU - over VDD_SMPS6 */
 + regulator-name = smps6;
 + regulator-min-microvolt = 
 85;
 + regulator-max-microvolt = 
 1250;
 + regulator-boot-on;
 + };
 +
 + smps7_reg: smps7 {
 + /* CORE_VDD */
 + regulator-name = smps7;
 + regulator-min-microvolt = 
 85;
 + regulator-max-microvolt = 
 103;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps8_reg: smps8 {
 + /* VDD_IVAHD */
 + regulator-name = smps8;
 + regulator-min-microvolt =  
 85;
 + regulator-max-microvolt = 
 125;
 + regulator-boot-on;
 + };
 +
 + smps9_reg: smps9 {
 + /* VDDS1V8 */
 + regulator-name = smps9;
 + regulator-min-microvolt = 
 180;
 + regulator-max-microvolt = 
 180;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + ldo1_reg: ldo1 {
 + /* LDO1_OUT -- SDIO  */
 + regulator-name = ldo1;
 + regulator-min-microvolt = 
 180;
 + regulator-max-microvolt = 
 330;
 + regulator-boot-on;
 + };
 +
 + ldo2_reg: ldo2 {
 + /* VDD_RTCIO */
 + /* LDO2 - VDDSHV5, LDO2 also 
 goes to CAN_PHY_3V3 */
 + regulator-name = ldo2;
 + regulator-min-microvolt 

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-03 Thread Keerthy

Benoit,


On Monday 26 August 2013 11:06 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.


Any comments on this patch?


Signed-off-by: Keerthy 
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<115>;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<1250>;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = "smps7";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<103>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = "smps9";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT --> SDIO  */
+   regulator-name = "ldo1";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<330>;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 -> VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+  

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-09-03 Thread Keerthy

Benoit,


On Monday 26 August 2013 11:06 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.


Any comments on this patch?


Signed-off-by: Keerthy j-keer...@ti.com
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
115;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
1250;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = smps7;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
103;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT -- SDIO  */
+   regulator-name = ldo1;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
330;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 - VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+   regulator-name = ldo2;

[PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-25 Thread Keerthy
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy 
---
 arch/arm/boot/dts/dra7-evm.dts |  118 
 1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<115>;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<1250>;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = "smps7";
+   regulator-min-microvolt = 
<85>;
+   regulator-max-microvolt = 
<103>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 
85>;
+   regulator-max-microvolt = 
<125>;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = "smps9";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT --> SDIO  */
+   regulator-name = "ldo1";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<330>;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 -> VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+   regulator-name = "ldo2";
+   

[PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-25 Thread Keerthy
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on top of:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Boot Tested on DRA7 d1 Board.

Signed-off-by: Keerthy j-keer...@ti.com
---
 arch/arm/boot/dts/dra7-evm.dts |  118 
 1 file changed, 118 insertions(+)

Index: linux/arch/arm/boot/dts/dra7-evm.dts
===
--- linux.orig/arch/arm/boot/dts/dra7-evm.dts   2013-08-26 09:57:52.496173554 
+0530
+++ linux/arch/arm/boot/dts/dra7-evm.dts2013-08-26 10:38:44.995414695 
+0530
@@ -93,6 +93,119 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
115;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
1250;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* CORE_VDD */
+   regulator-name = smps7;
+   regulator-min-microvolt = 
85;
+   regulator-max-microvolt = 
103;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  
85;
+   regulator-max-microvolt = 
125;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDDS1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT -- SDIO  */
+   regulator-name = ldo1;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
330;
+   regulator-boot-on;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   /* LDO2 - VDDSHV5, LDO2 also 
goes to CAN_PHY_3V3 */
+   regulator-name = ldo2;
+   regulator-min-microvolt = 
330;
+  

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-16 Thread Keerthy

Hi Nishanth,


On Thursday 15 August 2013 05:05 AM, Nishanth Menon wrote:

linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,


My Bad. I will resend with looping in both the lists and the comments
addressed.


I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy 
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,124 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+   interrupt-controller;
+   #interrupt-cells = <2>;

Where is the interrupt line to MPU? if it is not hooked up, why the
interrupt controller?


It is not hooked up. I will remove this.




+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */

^^ tab issue?

+   regulator-name = "smps123";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<150>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = 
<60>;
+   regulator-max-microvolt = 
<1310>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* VDDS_CORE */
+   regulator-name = "smps7";
+   regulator-min-microvolt = 
<60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDD_1V8 */
+   regulator-name = "smps9";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+  

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-16 Thread Balaji T K

On Thursday 15 August 2013 05:05 AM, Nishanth Menon wrote:

linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,

I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy 
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts




+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT --> SDIO  */
+   regulator-name = "ldo1";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<330>;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   regulator-name = "ldo2";
+   regulator-min-microvolt = 
<330>;
+   regulator-max-microvolt = 
<330>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo3_reg: ldo3 {
+   /* VDDA_1V8 PHYs */
+   regulator-name = "ldo3";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   };
+
+   ldo9_reg: ldo9 {
+   /* VDD_RTC */
+   regulator-name = "ldo9";
+   regulator-min-microvolt = 
<100>;
+   regulator-max-microvolt = 
<100>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   ldoln_reg: ldoln {
+   /* VDDA_1v8: PLLs */
+   regulator-name = "ldoln";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldousb_reg: ldousb {
+   /* VDDA_3V_USB: VDDA_USBHS33 */
+   regulator-name = "ldousb";
+   regulator-min-microvolt = 
<325>;
+   regulator-max-microvolt = 
<325>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   };
+   };
+   };


Who are using these LDOs? Example SDIO LDO should be linked up with
MMC instance, no? how about the PLLs and PHYs?



ldo1_reg would be linked in follow up patches which enables sd/mmc.




  };

   {





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-16 Thread Balaji T K

On Thursday 15 August 2013 05:05 AM, Nishanth Menon wrote:

linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,

I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy j-keer...@ti.com
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts

snip


+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT -- SDIO  */
+   regulator-name = ldo1;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
330;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   regulator-name = ldo2;
+   regulator-min-microvolt = 
330;
+   regulator-max-microvolt = 
330;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo3_reg: ldo3 {
+   /* VDDA_1V8 PHYs */
+   regulator-name = ldo3;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   };
+
+   ldo9_reg: ldo9 {
+   /* VDD_RTC */
+   regulator-name = ldo9;
+   regulator-min-microvolt = 
100;
+   regulator-max-microvolt = 
100;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+
+   ldoln_reg: ldoln {
+   /* VDDA_1v8: PLLs */
+   regulator-name = ldoln;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldousb_reg: ldousb {
+   /* VDDA_3V_USB: VDDA_USBHS33 */
+   regulator-name = ldousb;
+   regulator-min-microvolt = 
325;
+   regulator-max-microvolt = 
325;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   };
+   };
+   };


Who are using these LDOs? Example SDIO LDO should be linked up with
MMC instance, no? how about the PLLs and PHYs?



ldo1_reg would be linked in follow up patches which enables sd/mmc.




  };

  i2c2 {





--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-16 Thread Keerthy

Hi Nishanth,


On Thursday 15 August 2013 05:05 AM, Nishanth Menon wrote:

linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,


My Bad. I will resend with looping in both the lists and the comments
addressed.


I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:

The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy j-keer...@ti.com
---
  arch/arm/boot/dts/dra7-evm.dts |  118 
  1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,124 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+   interrupt-controller;
+   #interrupt-cells = 2;

Where is the interrupt line to MPU? if it is not hooked up, why the
interrupt controller?


It is not hooked up. I will remove this.




+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */

^^ tab issue?

+   regulator-name = smps123;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
150;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 
60;
+   regulator-max-microvolt = 
1310;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* VDDS_CORE */
+   regulator-name = smps7;
+   regulator-min-microvolt = 
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDD_1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-14 Thread Nishanth Menon
linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,

I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:
> The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
> 
> It is based on:
> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
> 
> Documentation:Documentation/devicetree/bindings/mfd/palmas.txt
>   Documentation/devicetree/bindings/regulator/palmas-pmic.txt 
> 
> 
> Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.
> 
> Signed-off-by: Keerthy 
> ---
>  arch/arm/boot/dts/dra7-evm.dts |  118 
> 
>  1 file changed, 118 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index b270e24..96f409f 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -93,6 +93,124 @@
>   pinctrl-names = "default";
>   pinctrl-0 = <_pins>;
>   clock-frequency = <40>;
> +
> + tps659038: tps659038@58 {
> + compatible = "ti,tps659038";
> + reg = <0x58>;
> + interrupt-controller;
> + #interrupt-cells = <2>;

Where is the interrupt line to MPU? if it is not hooked up, why the
interrupt controller?

> +
> + tps659038_pmic {
> + compatible = "ti,tps659038-pmic";
> +
> + regulators {
> + smps123_reg: smps123 {
> + /* VDD_MPU */
^^ tab issue?
> + regulator-name = "smps123";
> + regulator-min-microvolt = < 
> 60>;
> + regulator-max-microvolt = 
> <150>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps45_reg: smps45 {
> + /* VDD_DSPEVE */
> + regulator-name = "smps45";
> + regulator-min-microvolt = < 
> 60>;
> + regulator-max-microvolt = 
> <131>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps6_reg: smps6 {
> + /* VDD_GPU - over VDD_SMPS6 */
> + regulator-name = "smps6";
> + regulator-min-microvolt = 
> <60>;
> + regulator-max-microvolt = 
> <1310>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps7_reg: smps7 {
> + /* VDDS_CORE */
> + regulator-name = "smps7";
> + regulator-min-microvolt = 
> <60>;
> + regulator-max-microvolt = 
> <131>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps8_reg: smps8 {
> + /* VDD_IVAHD */
> + regulator-name = "smps8";
> + regulator-min-microvolt = < 
> 60>;
> + regulator-max-microvolt = 
> <131>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps9_reg: smps9 {
> + /* VDD_1V8 */
> + regulator-name = "smps9";
> + regulator-min-microvolt = 
> <180>;
> + regulator-max-microvolt = 
> <180>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldo1_reg: ldo1 {
> + /* LDO1_OUT --> SDIO  */
> +  

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-14 Thread Nishanth Menon
linux-omap, linux-arm-list should also be CCed, Benoit needs to be
addressed for allowing him to merge,

I have not done a proper schematics Vs data manual review yet
(apologies on that), but, a couple of comments:

On 08/13/2013 12:42 AM, Keerthy wrote:
 The Patch adds nodes for TPS659038 PMIC for DRA7 boards.
 
 It is based on:
 http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.
 
 Documentation:Documentation/devicetree/bindings/mfd/palmas.txt
   Documentation/devicetree/bindings/regulator/palmas-pmic.txt 
 
 
 Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.
 
 Signed-off-by: Keerthy j-keer...@ti.com
 ---
  arch/arm/boot/dts/dra7-evm.dts |  118 
 
  1 file changed, 118 insertions(+)
 
 diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
 index b270e24..96f409f 100644
 --- a/arch/arm/boot/dts/dra7-evm.dts
 +++ b/arch/arm/boot/dts/dra7-evm.dts
 @@ -93,6 +93,124 @@
   pinctrl-names = default;
   pinctrl-0 = i2c1_pins;
   clock-frequency = 40;
 +
 + tps659038: tps659038@58 {
 + compatible = ti,tps659038;
 + reg = 0x58;
 + interrupt-controller;
 + #interrupt-cells = 2;

Where is the interrupt line to MPU? if it is not hooked up, why the
interrupt controller?

 +
 + tps659038_pmic {
 + compatible = ti,tps659038-pmic;
 +
 + regulators {
 + smps123_reg: smps123 {
 + /* VDD_MPU */
^^ tab issue?
 + regulator-name = smps123;
 + regulator-min-microvolt =  
 60;
 + regulator-max-microvolt = 
 150;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps45_reg: smps45 {
 + /* VDD_DSPEVE */
 + regulator-name = smps45;
 + regulator-min-microvolt =  
 60;
 + regulator-max-microvolt = 
 131;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps6_reg: smps6 {
 + /* VDD_GPU - over VDD_SMPS6 */
 + regulator-name = smps6;
 + regulator-min-microvolt = 
 60;
 + regulator-max-microvolt = 
 1310;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps7_reg: smps7 {
 + /* VDDS_CORE */
 + regulator-name = smps7;
 + regulator-min-microvolt = 
 60;
 + regulator-max-microvolt = 
 131;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps8_reg: smps8 {
 + /* VDD_IVAHD */
 + regulator-name = smps8;
 + regulator-min-microvolt =  
 60;
 + regulator-max-microvolt = 
 131;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + smps9_reg: smps9 {
 + /* VDD_1V8 */
 + regulator-name = smps9;
 + regulator-min-microvolt = 
 180;
 + regulator-max-microvolt = 
 180;
 + regulator-always-on;
 + regulator-boot-on;
 + };
 +
 + ldo1_reg: ldo1 {
 + /* LDO1_OUT -- SDIO  */
 + regulator-name = ldo1;
 + 

[PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-12 Thread Keerthy
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy 
---
 arch/arm/boot/dts/dra7-evm.dts |  118 
 1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,124 @@
pinctrl-names = "default";
pinctrl-0 = <_pins>;
clock-frequency = <40>;
+
+   tps659038: tps659038@58 {
+   compatible = "ti,tps659038";
+   reg = <0x58>;
+   interrupt-controller;
+   #interrupt-cells = <2>;
+
+   tps659038_pmic {
+   compatible = "ti,tps659038-pmic";
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = "smps123";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<150>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = "smps45";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = "smps6";
+   regulator-min-microvolt = 
<60>;
+   regulator-max-microvolt = 
<1310>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* VDDS_CORE */
+   regulator-name = "smps7";
+   regulator-min-microvolt = 
<60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = "smps8";
+   regulator-min-microvolt = < 
60>;
+   regulator-max-microvolt = 
<131>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDD_1V8 */
+   regulator-name = "smps9";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<180>;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT --> SDIO  */
+   regulator-name = "ldo1";
+   regulator-min-microvolt = 
<180>;
+   regulator-max-microvolt = 
<330>;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   regulator-name = "ldo2";
+

[PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-12 Thread Keerthy
The Patch adds nodes for TPS659038 PMIC for DRA7 boards.

It is based on:
http://comments.gmane.org/gmane.linux.ports.arm.omap/102459.

Documentation:  Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/regulator/palmas-pmic.txt 


Tested on DRA7 Board, 3.11-rc5 plus the above patch-set.

Signed-off-by: Keerthy j-keer...@ti.com
---
 arch/arm/boot/dts/dra7-evm.dts |  118 
 1 file changed, 118 insertions(+)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index b270e24..96f409f 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -93,6 +93,124 @@
pinctrl-names = default;
pinctrl-0 = i2c1_pins;
clock-frequency = 40;
+
+   tps659038: tps659038@58 {
+   compatible = ti,tps659038;
+   reg = 0x58;
+   interrupt-controller;
+   #interrupt-cells = 2;
+
+   tps659038_pmic {
+   compatible = ti,tps659038-pmic;
+
+   regulators {
+   smps123_reg: smps123 {
+   /* VDD_MPU */
+   regulator-name = smps123;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
150;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps45_reg: smps45 {
+   /* VDD_DSPEVE */
+   regulator-name = smps45;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps6_reg: smps6 {
+   /* VDD_GPU - over VDD_SMPS6 */
+   regulator-name = smps6;
+   regulator-min-microvolt = 
60;
+   regulator-max-microvolt = 
1310;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps7_reg: smps7 {
+   /* VDDS_CORE */
+   regulator-name = smps7;
+   regulator-min-microvolt = 
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps8_reg: smps8 {
+   /* VDD_IVAHD */
+   regulator-name = smps8;
+   regulator-min-microvolt =  
60;
+   regulator-max-microvolt = 
131;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   smps9_reg: smps9 {
+   /* VDD_1V8 */
+   regulator-name = smps9;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
180;
+   regulator-always-on;
+   regulator-boot-on;
+   };
+
+   ldo1_reg: ldo1 {
+   /* LDO1_OUT -- SDIO  */
+   regulator-name = ldo1;
+   regulator-min-microvolt = 
180;
+   regulator-max-microvolt = 
330;
+   };
+
+   ldo2_reg: ldo2 {
+   /* VDD_RTCIO */
+   regulator-name = ldo2;
+