Re: [PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-21 Thread Nick Desaulniers
On Wed, Aug 21, 2019 at 10:43 AM Nathan Huckleberry wrote: > > On Tue, Aug 20, 2019 at 2:39 PM Nick Desaulniers > wrote: > > > > On Tue, Aug 20, 2019 at 12:44 PM Nathan Huckleberry > > wrote: ...snip... > > > +tstr1, #0x10 @ 26 or 32-bit mode? > > > +moveq mask, #0xfc03

Re: [PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-21 Thread Nathan Huckleberry
On Tue, Aug 20, 2019 at 2:39 PM Nick Desaulniers wrote: > > On Tue, Aug 20, 2019 at 12:44 PM Nathan Huckleberry wrote: > > > > The stackframe setup when compiled with clang is different. > > Since the stack unwinder expects the gcc stackframe setup it > > fails to print backtraces. This patch

Re: [PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-20 Thread Nick Desaulniers
On Tue, Aug 20, 2019 at 12:44 PM Nathan Huckleberry wrote: > > The stackframe setup when compiled with clang is different. > Since the stack unwinder expects the gcc stackframe setup it > fails to print backtraces. This patch adds support for the > clang stackframe setup. > > Link:

[PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-20 Thread Nathan Huckleberry
The stackframe setup when compiled with clang is different. Since the stack unwinder expects the gcc stackframe setup it fails to print backtraces. This patch adds support for the clang stackframe setup. Link: https://github.com/ClangBuiltLinux/linux/issues/35 Cc:

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-12 Thread Nick Desaulniers
On Thu, Aug 1, 2019 at 4:10 PM 'Nathan Huckleberry' via Clang Built Linux wrote: > > The stackframe setup when compiled with clang is different. > Since the stack unwinder expects the gcc stackframe setup it > fails to print backtraces. This patch adds support for the > clang stackframe setup. >

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-07 Thread Dave Martin
On Tue, Aug 06, 2019 at 02:29:16PM -0700, Nathan Huckleberry wrote: > I'm not sure that we should disable a broken feature instead of > attempting a fix. > > CONFIG_FUNCTION_GRAPH_TRACER is dependent on CONFIG_FRAME_POINTER and > there have been reports by MediaTek that the frame pointer unwinder

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-06 Thread Nathan Huckleberry
I'm not sure that we should disable a broken feature instead of attempting a fix. CONFIG_FUNCTION_GRAPH_TRACER is dependent on CONFIG_FRAME_POINTER and there have been reports by MediaTek that the frame pointer unwinder is faster in some cases. On Mon, Aug 5, 2019 at 6:39 AM Dave Martin wrote:

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-05 Thread Dave Martin
On Fri, Aug 02, 2019 at 10:27:30AM -0700, Nathan Huckleberry wrote: > You're right. Would pushing an extra register be an adequate fix? Would forcing CONFIG_ARM_UNWIND=y for clang work as an alternative to this? Assuming clang supports -funwind-tables or equivalent, this may just work. [...]

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-02 Thread Nathan Huckleberry
You're right. Would pushing an extra register be an adequate fix? On Fri, Aug 2, 2019 at 7:24 AM Robin Murphy wrote: > > On 02/08/2019 00:10, Nathan Huckleberry wrote: > > The stackframe setup when compiled with clang is different. > > Since the stack unwinder expects the gcc stackframe setup it

Re: [RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-02 Thread Robin Murphy
On 02/08/2019 00:10, Nathan Huckleberry wrote: The stackframe setup when compiled with clang is different. Since the stack unwinder expects the gcc stackframe setup it fails to print backtraces. This patch adds support for the clang stackframe setup. Cc: clang-built-li...@googlegroups.com

[RFC PATCH] ARM: UNWINDER_FRAME_POINTER implementation for Clang

2019-08-01 Thread Nathan Huckleberry
The stackframe setup when compiled with clang is different. Since the stack unwinder expects the gcc stackframe setup it fails to print backtraces. This patch adds support for the clang stackframe setup. Cc: clang-built-li...@googlegroups.com Suggested-by: Tri Vo Signed-off-by: Nathan