Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-05 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > > > + 72xx165@0 { > > > > > > Please use a generic name for the node. > > > > This is a bit tricky. > > What about using 'gpio@0' like described in >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-05 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > > > + 72xx165@0 { > > > > > > Please use a generic name for the node. > > > > This is a bit tricky. > > What about using 'gpio@0' like described in >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Fabio Estevam
Hi Lukasz, On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > + 72xx165@0 { > > > > Please use a generic name for the node. > > This is a bit tricky. What about using 'gpio@0' like described in Documentation/devicetree/bindings/gpio/gpio-pisosr.txt ?

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Fabio Estevam
Hi Lukasz, On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > + 72xx165@0 { > > > > Please use a generic name for the node. > > This is a bit tricky. What about using 'gpio@0' like described in Documentation/devicetree/bindings/gpio/gpio-pisosr.txt ?

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Lukasz Majewski
Hi Shawn, Thank you for the review. > On Tue, Nov 13, 2018 at 01:12:13PM +0100, Lukasz Majewski wrote: > > The procedure to read this ID value is as follows: > > > > rmmod spi_fsl_dspi > > insmod spi-gpio.ko > > > > echo 504 > /sys/class/gpio/export > > cat /sys/class/gpio/gpio504/value > >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Lukasz Majewski
Hi Shawn, Thank you for the review. > On Tue, Nov 13, 2018 at 01:12:13PM +0100, Lukasz Majewski wrote: > > The procedure to read this ID value is as follows: > > > > rmmod spi_fsl_dspi > > insmod spi-gpio.ko > > > > echo 504 > /sys/class/gpio/export > > cat /sys/class/gpio/gpio504/value > >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-11-26 Thread Shawn Guo
On Tue, Nov 13, 2018 at 01:12:13PM +0100, Lukasz Majewski wrote: > The procedure to read this ID value is as follows: > > rmmod spi_fsl_dspi > insmod spi-gpio.ko > > echo 504 > /sys/class/gpio/export > cat /sys/class/gpio/gpio504/value > ... > echo 511 > /sys/class/gpio/export > cat

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-11-26 Thread Shawn Guo
On Tue, Nov 13, 2018 at 01:12:13PM +0100, Lukasz Majewski wrote: > The procedure to read this ID value is as follows: > > rmmod spi_fsl_dspi > insmod spi-gpio.ko > > echo 504 > /sys/class/gpio/export > cat /sys/class/gpio/gpio504/value > ... > echo 511 > /sys/class/gpio/export > cat

[PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-11-13 Thread Lukasz Majewski
The procedure to read this ID value is as follows: rmmod spi_fsl_dspi insmod spi-gpio.ko echo 504 > /sys/class/gpio/export cat /sys/class/gpio/gpio504/value ... echo 511 > /sys/class/gpio/export cat /sys/class/gpio/gpio511/value rmmod spi-gpio.ko insmod spi_fsl_dspi Signed-off-by: Lukasz

[PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-11-13 Thread Lukasz Majewski
The procedure to read this ID value is as follows: rmmod spi_fsl_dspi insmod spi-gpio.ko echo 504 > /sys/class/gpio/export cat /sys/class/gpio/gpio504/value ... echo 511 > /sys/class/gpio/export cat /sys/class/gpio/gpio511/value rmmod spi-gpio.ko insmod spi_fsl_dspi Signed-off-by: Lukasz