Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Drop redundant I2C properties
On Sat, Aug 24, 2019 at 12:12 PM Shawn Guo wrote: > > On Mon, Aug 19, 2019 at 08:19:52PM -0700, Andrey Smirnov wrote: > > Drop redundant I2C properties that are already specified in > > vf610-zii-dev.dtsi > > > > Signed-off-by: Andrey Smirnov > > Cc: Shawn Guo > > Cc: Chris Healy > > Cc: Fabio Estevam > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 10 -- > > 1 file changed, 10 deletions(-) > > > > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > > b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > > index 48086c5e8549..e500911ce0a5 100644 > > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > > @@ -323,11 +323,6 @@ > > }; > > > > { > > - clock-frequency = <10>; > > - pinctrl-names = "default"; > > - pinctrl-0 = <_i2c0>; > > pinctrl for i2c0 is not same as what vf610-zii-dev.dtsi has. The only difference I can see is in pinctrl-names so I am assuming that's what you mean. Not configuring I2C recovery on Rev B board was not intentional. I'll update commit log in v2. Thanks, Andrey Smirnov
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Drop redundant I2C properties
On Mon, Aug 19, 2019 at 08:19:52PM -0700, Andrey Smirnov wrote: > Drop redundant I2C properties that are already specified in > vf610-zii-dev.dtsi > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Fabio Estevam > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > index 48086c5e8549..e500911ce0a5 100644 > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > @@ -323,11 +323,6 @@ > }; > > { > - clock-frequency = <10>; > - pinctrl-names = "default"; > - pinctrl-0 = <_i2c0>; pinctrl for i2c0 is not same as what vf610-zii-dev.dtsi has. Shawn > - status = "okay"; > - > gpio5: io-expander@20 { > compatible = "nxp,pca9554"; > reg = <0x20>; > @@ -350,11 +345,6 @@ > }; > > { > - clock-frequency = <10>; > - pinctrl-names = "default"; > - pinctrl-0 = <_i2c2>; > - status = "okay"; > - > tca9548@70 { > compatible = "nxp,pca9548"; > pinctrl-0 = <_i2c_mux_reset>; > -- > 2.21.0 >
[PATCH] ARM: dts: vf610-zii-dev-rev-b: Drop redundant I2C properties
Drop redundant I2C properties that are already specified in vf610-zii-dev.dtsi Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Fabio Estevam Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index 48086c5e8549..e500911ce0a5 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts @@ -323,11 +323,6 @@ }; { - clock-frequency = <10>; - pinctrl-names = "default"; - pinctrl-0 = <_i2c0>; - status = "okay"; - gpio5: io-expander@20 { compatible = "nxp,pca9554"; reg = <0x20>; @@ -350,11 +345,6 @@ }; { - clock-frequency = <10>; - pinctrl-names = "default"; - pinctrl-0 = <_i2c2>; - status = "okay"; - tca9548@70 { compatible = "nxp,pca9548"; pinctrl-0 = <_i2c_mux_reset>; -- 2.21.0