Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Doug Anderson
Hi, On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd wrote: > Can you add the backtrace? Good point. Done. > Perhaps it would be better to add a different function for the kgdb call > site? Then it's explicit what's going on without us having to figure out > when in_dbg_master() is true.

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Doug Anderson
Kees, On Tue, Aug 25, 2015 at 9:50 AM, Kees Cook wrote: > On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd wrote: >> On 08/24/2015 04:58 PM, Douglas Anderson wrote: >>> >>> If we're in kgdb then the machine is already stopped. Trying to stop >>> it again will cause us to try to sleep, which is

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Kees Cook
On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd wrote: > On 08/24/2015 04:58 PM, Douglas Anderson wrote: >> >> If we're in kgdb then the machine is already stopped. Trying to stop >> it again will cause us to try to sleep, which is not allowed while in >> kgdb. To avoid this problem, only stop

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Kees Cook
On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/24/2015 04:58 PM, Douglas Anderson wrote: If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us to try to sleep, which is not allowed while in kgdb. To avoid this problem,

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Doug Anderson
Hi, On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd sb...@codeaurora.org wrote: Can you add the backtrace? Good point. Done. Perhaps it would be better to add a different function for the kgdb call site? Then it's explicit what's going on without us having to figure out when in_dbg_master()

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-25 Thread Doug Anderson
Kees, On Tue, Aug 25, 2015 at 9:50 AM, Kees Cook keesc...@chromium.org wrote: On Mon, Aug 24, 2015 at 5:19 PM, Stephen Boyd sb...@codeaurora.org wrote: On 08/24/2015 04:58 PM, Douglas Anderson wrote: If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-24 Thread Stephen Boyd
On 08/24/2015 04:58 PM, Douglas Anderson wrote: If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us to try to sleep, which is not allowed while in kgdb. To avoid this problem, only stop the machine when we're not in kgdb. Reported-by: Aapo Vienamo

[PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-24 Thread Douglas Anderson
If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us to try to sleep, which is not allowed while in kgdb. To avoid this problem, only stop the machine when we're not in kgdb. Reported-by: Aapo Vienamo Suggested-by: Kees Cook Signed-off-by: Douglas

Re: [PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-24 Thread Stephen Boyd
On 08/24/2015 04:58 PM, Douglas Anderson wrote: If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us to try to sleep, which is not allowed while in kgdb. To avoid this problem, only stop the machine when we're not in kgdb. Reported-by: Aapo Vienamo

[PATCH] ARM: probes: Don't stop the machine if we're in the debugger

2015-08-24 Thread Douglas Anderson
If we're in kgdb then the machine is already stopped. Trying to stop it again will cause us to try to sleep, which is not allowed while in kgdb. To avoid this problem, only stop the machine when we're not in kgdb. Reported-by: Aapo Vienamo avien...@nvidia.com Suggested-by: Kees Cook