Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-16 Thread Mark Brown
On Mon, Jan 13, 2014 at 06:45:36AM +, Ben Dooks wrote: > - If pm-runtime is not enabled then we need something to manage the > clocks for the driver. If we put that code in the driver then there > is not a lot of point in having the pm-runtime clock code here as > the driver really only

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-13 Thread Laurent Pinchart
Hi Ben, On Monday 13 January 2014 06:45:36 Ben Dooks wrote: > On 12/01/14 22:01, Laurent Pinchart wrote: > > On Sunday 12 January 2014 22:54:15 Laurent Pinchart wrote: > >> Hi Ben, > >> > >> Thank you for the patch. > >> > >> On Saturday 11 January 2014 13:06:29 Ben Dooks wrote: > >>> If the ker

[PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-13 Thread Ben Dooks
If the kernel is built to support multi-arm configurmation with shmobile support built in, then the drivers/sh is not built. This contains drivers that are essential to devices support by that configuration, including the PM runtime code in drivers/sh/pm_runtime.c (which implicitly enables the bus

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-13 Thread Geert Uytterhoeven
Hi Ben, On Mon, Jan 13, 2014 at 10:35 AM, Ben Dooks wrote: > On 13/01/14 09:28, Geert Uytterhoeven wrote: >> On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks >> wrote: >>> >>> --- a/drivers/sh/Makefile >>> +++ b/drivers/sh/Makefile >>> @@ -3,7 +3,10 @@ >>> # >>> obj-y := intc/ >>> >>> +ifeq ($(CO

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-13 Thread Ben Dooks
On 13/01/14 09:28, Geert Uytterhoeven wrote: On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks wrote: --- a/drivers/sh/Makefile +++ b/drivers/sh/Makefile @@ -3,7 +3,10 @@ # obj-y := intc/ +ifeq ($(CONFIG_COMMON_CLK),n) obj-$(CONFIG_HAVE_CLK) += clk/ +endif + This part breaks my Koels

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-13 Thread Geert Uytterhoeven
On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks wrote: > --- a/drivers/sh/Makefile > +++ b/drivers/sh/Makefile > @@ -3,7 +3,10 @@ > # > obj-y := intc/ > > +ifeq ($(CONFIG_COMMON_CLK),n) > obj-$(CONFIG_HAVE_CLK) += clk/ > +endif > + This part breaks my Koelsch legacy (non-reference) build:

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-12 Thread Ben Dooks
On 12/01/14 22:01, Laurent Pinchart wrote: Hi Ben, On Sunday 12 January 2014 22:54:15 Laurent Pinchart wrote: Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:06:29 Ben Dooks wrote: If the kernel is built to support multi-arm configurmation with shmobile support built in, then

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-12 Thread Ben Dooks
On 13/01/14 00:30, Simon Horman wrote: On Fri, Jan 10, 2014 at 03:18:15PM +, Ben Dooks wrote: If the kernel is built to support multi-arm configurmation with shmobile support built in, then the drivers/sh is not built. This contains drivers that are essential to devices support by that confi

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-12 Thread Simon Horman
On Fri, Jan 10, 2014 at 03:18:15PM +, Ben Dooks wrote: > If the kernel is built to support multi-arm configurmation with shmobile > support built in, then the drivers/sh is not built. This contains drivers > that are essential to devices support by that configuration, including the > PM runtime

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-12 Thread Laurent Pinchart
Hi Ben, On Sunday 12 January 2014 22:54:15 Laurent Pinchart wrote: > Hi Ben, > > Thank you for the patch. > > On Saturday 11 January 2014 13:06:29 Ben Dooks wrote: > > If the kernel is built to support multi-arm configurmation with shmobile > > support built in, then the drivers/sh is not built.

Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-12 Thread Laurent Pinchart
Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:06:29 Ben Dooks wrote: > If the kernel is built to support multi-arm configurmation with shmobile > support built in, then the drivers/sh is not built. This contains drivers > that are essential to devices support by that configurati

[PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-10 Thread Ben Dooks
If the kernel is built to support multi-arm configurmation with shmobile support built in, then the drivers/sh is not built. This contains drivers that are essential to devices support by that configuration, including the PM runtime code in drivers/sh/pm_runtime.c (which implicitly enables the bus