Re: [PATCH] ARM: zx: Fix error handling

On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote: > 'devm_ioremap_resource()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > 'return -EIO;' could also be turned into

Re: [PATCH] ARM: zx: Fix error handling

On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote: > 'devm_ioremap_resource()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > 'return -EIO;' could also be turned into 'return PTR_ERR(pcubase);' in >

Re: [PATCH] ARM: zx: Fix error handling

Same as the other fix... On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote: > 'devm_ioremap_resource()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > 'return -EIO;'

Re: [PATCH] ARM: zx: Fix error handling

Same as the other fix... On Sun, Oct 30, 2016 at 09:10:10AM +0100, Christophe JAILLET wrote: > 'devm_ioremap_resource()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > 'return -EIO;' could also be turned into 'return

[PATCH] ARM: zx: Fix error handling

'devm_ioremap_resource()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET --- 'return -EIO;' could also be turned into 'return PTR_ERR(pcubase);' in order to propagate the error value. ---

[PATCH] ARM: zx: Fix error handling

'devm_ioremap_resource()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET --- 'return -EIO;' could also be turned into 'return PTR_ERR(pcubase);' in order to propagate the error value. --- arch/arm/mach-zx/zx296702-pm-domain.c | 2