Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin

[Gregory CLEMENT]

Hi Marcin,
 
 On mer., août 02 2017, Miquel RAYNAL  wrote:

> Hi,
>
> On Fri, 21 Jul 2017 01:50:36 +0200
> Marcin Wojtas  wrote:
>
>> The ESPRESSObin board exposes one of the SDHCI interfaces
>> via J1 uSD slot. This patch enables it.
>> 
>> Signed-off-by: Marcin Wojtas 
>> Signed-off-by: Zbigniew Bodek 
>
> Tested-by: Miquel Raynal 

Applied on mvebu/dt64 (I also removed the "no-1-8-v" property while
applying it becauseit was obviously wrong)

Thanks,

Gregory

>
>> ---
>>  .../boot/dts/marvell/armada-3720-espressobin.dts   | 26
>> ++ 1 file changed, 26 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
>> b1af3f98..6d0caf1 100644 ---
>> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
>> +45,7 @@ 
>>  /dts-v1/;
>>  
>> +#include 
>>  #include "armada-372x.dtsi"
>>  
>>  / {
>> @@ -59,6 +60,20 @@
>>  device_type = "memory";
>>  reg = <0x 0x 0x 0x2000>;
>>  };
>> +
>> +vcc_sd_reg1: regulator {
>> +compatible = "regulator-gpio";
>> +regulator-name = "vcc_sd1";
>> +regulator-min-microvolt = <180>;
>> +regulator-max-microvolt = <330>;
>> +regulator-boot-on;
>> +
>> +gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
>> +gpios-states = <0>;
>> +states = <180 0x1
>> +  330 0x0>;
>> +enable-active-high;
>> +};
>>  };
>>  
>>  /* J9 */
>> @@ -71,6 +86,17 @@
>>  status = "okay";
>>  };
>>  
>> +/* J1 */
>> +&sdhci1 {
>> +wp-inverted;
>> +bus-width = <4>;
>> +cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
>> +no-1-8-v;
>> +marvell,pad-type = "sd";
>> +vqmmc-supply = <&vcc_sd_reg1>;
>> +status = "okay";
>> +};
>> +
>>  /* Exported on the micro USB connector J5 through an FTDI */
>>  &uart0 {
>>  status = "okay";
>
>
>
> -- 
> Miquel Raynal, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin

[Miquel RAYNAL]

Hi,

On Fri, 21 Jul 2017 01:50:36 +0200
Marcin Wojtas  wrote:

> The ESPRESSObin board exposes one of the SDHCI interfaces
> via J1 uSD slot. This patch enables it.
> 
> Signed-off-by: Marcin Wojtas 
> Signed-off-by: Zbigniew Bodek 

Tested-by: Miquel Raynal 

> ---
>  .../boot/dts/marvell/armada-3720-espressobin.dts   | 26
> ++ 1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
> b1af3f98..6d0caf1 100644 ---
> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
> +45,7 @@ 
>  /dts-v1/;
>  
> +#include 
>  #include "armada-372x.dtsi"
>  
>  / {
> @@ -59,6 +60,20 @@
>   device_type = "memory";
>   reg = <0x 0x 0x 0x2000>;
>   };
> +
> + vcc_sd_reg1: regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "vcc_sd1";
> + regulator-min-microvolt = <180>;
> + regulator-max-microvolt = <330>;
> + regulator-boot-on;
> +
> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
> + gpios-states = <0>;
> + states = <180 0x1
> +   330 0x0>;
> + enable-active-high;
> + };
>  };
>  
>  /* J9 */
> @@ -71,6 +86,17 @@
>   status = "okay";
>  };
>  
> +/* J1 */
> +&sdhci1 {
> + wp-inverted;
> + bus-width = <4>;
> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
> + no-1-8-v;
> + marvell,pad-type = "sd";
> + vqmmc-supply = <&vcc_sd_reg1>;
> + status = "okay";
> +};
> +
>  /* Exported on the micro USB connector J5 through an FTDI */
>  &uart0 {
>   status = "okay";



-- 
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin

[Marcin Wojtas]

The ESPRESSObin board exposes one of the SDHCI interfaces
via J1 uSD slot. This patch enables it.

Signed-off-by: Marcin Wojtas 
Signed-off-by: Zbigniew Bodek 
---
 .../boot/dts/marvell/armada-3720-espressobin.dts   | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts 
b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index b1af3f98..6d0caf1 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -45,6 +45,7 @@
 
 /dts-v1/;
 
+#include 
 #include "armada-372x.dtsi"
 
 / {
@@ -59,6 +60,20 @@
device_type = "memory";
reg = <0x 0x 0x 0x2000>;
};
+
+   vcc_sd_reg1: regulator {
+   compatible = "regulator-gpio";
+   regulator-name = "vcc_sd1";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <330>;
+   regulator-boot-on;
+
+   gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+   gpios-states = <0>;
+   states = <180 0x1
+ 330 0x0>;
+   enable-active-high;
+   };
 };
 
 /* J9 */
@@ -71,6 +86,17 @@
status = "okay";
 };
 
+/* J1 */
+&sdhci1 {
+   wp-inverted;
+   bus-width = <4>;
+   cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
+   no-1-8-v;
+   marvell,pad-type = "sd";
+   vqmmc-supply = <&vcc_sd_reg1>;
+   status = "okay";
+};
+
 /* Exported on the micro USB connector J5 through an FTDI */
 &uart0 {
status = "okay";
-- 
1.8.3.1