RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-04-01 Thread Arun Shamanna Lakshmi
om'; 'linux- > ker...@vger.kernel.org' > Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > * PGP Signed by an unknown key > > On Mon, Mar 31, 2014 at 01:55:52PM +0200, Lars-Peter Clausen wrote: > > On 03/31/2014 01:21 PM, Mark Brown wrote: >

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-04-01 Thread Arun Shamanna Lakshmi
...@vger.kernel.org' Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux * PGP Signed by an unknown key On Mon, Mar 31, 2014 at 01:55:52PM +0200, Lars-Peter Clausen wrote: On 03/31/2014 01:21 PM, Mark Brown wrote: The above is a bit confusing... partly this is because

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Mark Brown
On Mon, Mar 31, 2014 at 01:55:52PM +0200, Lars-Peter Clausen wrote: > On 03/31/2014 01:21 PM, Mark Brown wrote: > >The above is a bit confusing... partly this is because of a lack of > >context (what is MULTI_MUX_INPUT_OFFSET?) and partly because it isn't > >entirely obvious that stopping as

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Lars-Peter Clausen
On 03/31/2014 01:21 PM, Mark Brown wrote: On Sat, Mar 29, 2014 at 11:12:30PM -0700, Arun Shamanna Lakshmi wrote: Fix your mailer to word wrap within paragraphs, your mails are excessively hard to read. I'm not sure I understand how that MUX_OFFSET would work. To get the selected mux output

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Mark Brown
On Sat, Mar 29, 2014 at 11:12:30PM -0700, Arun Shamanna Lakshmi wrote: Fix your mailer to word wrap within paragraphs, your mails are excessively hard to read. > > I'm not sure I understand how that MUX_OFFSET would work. To get the > > selected mux output you can use the ffs instruction. > >

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Mark Brown
On Sat, Mar 29, 2014 at 11:12:30PM -0700, Arun Shamanna Lakshmi wrote: Fix your mailer to word wrap within paragraphs, your mails are excessively hard to read. I'm not sure I understand how that MUX_OFFSET would work. To get the selected mux output you can use the ffs instruction.

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Lars-Peter Clausen
On 03/31/2014 01:21 PM, Mark Brown wrote: On Sat, Mar 29, 2014 at 11:12:30PM -0700, Arun Shamanna Lakshmi wrote: Fix your mailer to word wrap within paragraphs, your mails are excessively hard to read. I'm not sure I understand how that MUX_OFFSET would work. To get the selected mux output

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-31 Thread Mark Brown
On Mon, Mar 31, 2014 at 01:55:52PM +0200, Lars-Peter Clausen wrote: On 03/31/2014 01:21 PM, Mark Brown wrote: The above is a bit confusing... partly this is because of a lack of context (what is MULTI_MUX_INPUT_OFFSET?) and partly because it isn't entirely obvious that stopping as soon as we

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-30 Thread Arun Shamanna Lakshmi
g'; 'ti...@suse.de'; > 'linux-kernel@vger.kernel.org' > Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > On 03/29/2014 03:30 AM, Songhee Baek wrote: > >> -Original Message- > >> From: Songhee Baek > >> Sent: Friday, March 28,

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-30 Thread Arun Shamanna Lakshmi
-kernel@vger.kernel.org' Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/29/2014 03:30 AM, Songhee Baek wrote: -Original Message- From: Songhee Baek Sent: Friday, March 28, 2014 11:10 AM To: 'Lars-Peter Clausen' Cc: Arun Shamanna Lakshmi; 'lgirdw

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-29 Thread Lars-Peter Clausen
'; 'linux-kernel@vger.kernel.org' Subject: RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 11:41 PM, Songhee Baek wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: The way you describe this it seems to me that a value array for this kind of mux would

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-29 Thread Lars-Peter Clausen
'; 'linux-kernel@vger.kernel.org' Subject: RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 11:41 PM, Songhee Baek wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: The way you describe this it seems to me that a value array for this kind of mux would

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-28 Thread Songhee Baek
ernel@vger.kernel.org' > Subject: RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > > > > On 03/26/2014 11:41 PM, Songhee Baek wrote: > > > >> On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: > > > >> > > > >>

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-28 Thread Songhee Baek
> > On 03/26/2014 11:41 PM, Songhee Baek wrote: > > >> On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: > > >> > > >> The way you describe this it seems to me that a value array for > > >> this kind of mux would look like. > > >> > > >> 0x, 0x, 0x0001 > > >> 0x,

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-28 Thread Songhee Baek
On 03/26/2014 11:41 PM, Songhee Baek wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: The way you describe this it seems to me that a value array for this kind of mux would look like. 0x, 0x, 0x0001 0x, 0x, 0x0002

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-28 Thread Songhee Baek
' Subject: RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 11:41 PM, Songhee Baek wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: The way you describe this it seems to me that a value array for this kind of mux would look like

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-27 Thread Songhee Baek
de; > linux-kernel@vger.kernel.org > Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > On 03/26/2014 11:41 PM, Songhee Baek wrote: > >> -Original Message- > >> From: Lars-Peter Clausen [mailto:l...@metafoo.de] > >> Sent:

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-27 Thread Lars-Peter Clausen
-project.org; ti...@suse.de; linux- ker...@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-27 Thread Lars-Peter Clausen
-project.org; ti...@suse.de; linux- ker...@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-27 Thread Songhee Baek
@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 11:41 PM, Songhee Baek wrote: -Original Message- From: Lars-Peter Clausen [mailto:l...@metafoo.de] Sent: Wednesday, March 26, 2014 12:39 PM To: Arun Shamanna Lakshmi Cc: lgirdw

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Songhee Baek
roject.org; > swar...@wwwdotorg.org; ti...@suse.de; lgirdw...@gmail.com; linux- > ker...@vger.kernel.org > Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > * PGP Signed by an unknown key > > On Wed, Mar 26, 2014 at 08:38:47PM +0100, Lars-Peter Clausen

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Mark Brown
On Tue, Mar 25, 2014 at 05:02:35PM -0700, Arun Shamanna Lakshmi wrote: > + } > + if (!match) { > + dev_err(codec->dev, "ASoC: Failed to find matched enum > value\n"); > + return -EINVAL; > + } else > + ucontrol->value.enumerated.item[0] = i;

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Mark Brown
On Wed, Mar 26, 2014 at 08:38:47PM +0100, Lars-Peter Clausen wrote: > On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: > The way you describe this it seems to me that a value array for this kind of > mux would look like. > 0x, 0x, 0x0001 > 0x, 0x,

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Songhee Baek
e.de; linux- > ker...@vger.kernel.org > Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux > > On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: > > If the mux uses 1 bit position per input, and requires to set one > > single bit at a time, then an N b

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Lars-Peter Clausen
On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support up to N inputs. In more recent Tegra chips, we have at least greater than 64 inputs which requires at least 2 .reg

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Lars-Peter Clausen
On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support up to N inputs. In more recent Tegra chips, we have at least greater than 64 inputs which requires at least 2 .reg

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Songhee Baek
...@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support up to N inputs. In more recent

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Mark Brown
On Wed, Mar 26, 2014 at 08:38:47PM +0100, Lars-Peter Clausen wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi wrote: The way you describe this it seems to me that a value array for this kind of mux would look like. 0x, 0x, 0x0001 0x, 0x, 0x0002

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Mark Brown
On Tue, Mar 25, 2014 at 05:02:35PM -0700, Arun Shamanna Lakshmi wrote: + } + if (!match) { + dev_err(codec-dev, ASoC: Failed to find matched enum value\n); + return -EINVAL; + } else + ucontrol-value.enumerated.item[0] = i; Coding style

RE: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-26 Thread Songhee Baek
...@wwwdotorg.org; ti...@suse.de; lgirdw...@gmail.com; linux- ker...@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux * PGP Signed by an unknown key On Wed, Mar 26, 2014 at 08:38:47PM +0100, Lars-Peter Clausen wrote: On 03/26/2014 01:02 AM, Arun Shamanna Lakshmi

[PATCH] ASoC: Add support for multi register mux

2014-03-25 Thread Arun Shamanna Lakshmi
If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support up to N inputs. In more recent Tegra chips, we have at least greater than 64 inputs which requires at least 2 .reg fields in struct soc_enum. Signed-off-by: Arun Shamanna

[PATCH] ASoC: Add support for multi register mux

2014-03-25 Thread Arun Shamanna Lakshmi
If the mux uses 1 bit position per input, and requires to set one single bit at a time, then an N bit register can support up to N inputs. In more recent Tegra chips, we have at least greater than 64 inputs which requires at least 2 .reg fields in struct soc_enum. Signed-off-by: Arun Shamanna

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-21 Thread Mark Brown
On Thu, Mar 20, 2014 at 08:40:54PM +0100, Lars-Peter Clausen wrote: > On 03/20/2014 08:05 PM, Lars-Peter Clausen wrote: > >It might make sense to add special code for supported muxes with a one-hot > >encoding instead of using a value mux. Having an large array where each > >entry is just 1<

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-21 Thread Mark Brown
On Thu, Mar 20, 2014 at 08:40:54PM +0100, Lars-Peter Clausen wrote: On 03/20/2014 08:05 PM, Lars-Peter Clausen wrote: It might make sense to add special code for supported muxes with a one-hot encoding instead of using a value mux. Having an large array where each entry is just 1n is a bit

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Lars-Peter Clausen
On 03/20/2014 08:05 PM, Lars-Peter Clausen wrote: On 03/20/2014 07:36 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: If each bit of a 32

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Lars-Peter Clausen
On 03/20/2014 07:36 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: If each bit of a 32 bit register maps to an input of a mux, then with

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Mark Brown
On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: > On 03/20/2014 05:48 AM, Mark Brown wrote: > > On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: > >> If each bit of a 32 bit register maps to an input of a mux, then with > >> the current 'soc_enum' structure

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Stephen Warren
On 03/20/2014 05:48 AM, Mark Brown wrote: > On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: > > Don't top post and fix your mailer to word wrap within paragraphs, your > mail is very hard to read. > >> If each bit of a 32 bit register maps to an input of a mux, then with

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Mark Brown
On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: Don't top post and fix your mailer to word wrap within paragraphs, your mail is very hard to read. > If each bit of a 32 bit register maps to an input of a mux, then with > the current 'soc_enum' structure we cannot have more

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Mark Brown
On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: Don't top post and fix your mailer to word wrap within paragraphs, your mail is very hard to read. If each bit of a 32 bit register maps to an input of a mux, then with the current 'soc_enum' structure we cannot have more

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Stephen Warren
On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: Don't top post and fix your mailer to word wrap within paragraphs, your mail is very hard to read. If each bit of a 32 bit register maps to an input of a mux, then with the

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Mark Brown
On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: If each bit of a 32 bit register maps to an input of a mux, then with the current 'soc_enum' structure we cannot

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Lars-Peter Clausen
On 03/20/2014 07:36 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: If each bit of a 32 bit register maps to an input of a mux, then with

Re: [alsa-devel] [PATCH] ASoC: Add support for multi register mux

2014-03-20 Thread Lars-Peter Clausen
On 03/20/2014 08:05 PM, Lars-Peter Clausen wrote: On 03/20/2014 07:36 PM, Mark Brown wrote: On Thu, Mar 20, 2014 at 12:20:17PM -0600, Stephen Warren wrote: On 03/20/2014 05:48 AM, Mark Brown wrote: On Wed, Mar 19, 2014 at 04:44:00PM -0700, Arun Shamanna Lakshmi wrote: If each bit of a 32

RE: [PATCH] ASoC: Add support for multi register mux

2014-03-19 Thread Arun Shamanna Lakshmi
to:broo...@kernel.org] Sent: Tuesday, March 18, 2014 5:00 PM To: Arun Shamanna Lakshmi Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.de; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Songhee Baek Subject: Re: [PATCH] ASoC: Add support for multi register mux * PGP Signe

RE: [PATCH] ASoC: Add support for multi register mux

2014-03-19 Thread Arun Shamanna Lakshmi
...@gmail.com; pe...@perex.cz; ti...@suse.de; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Songhee Baek Subject: Re: [PATCH] ASoC: Add support for multi register mux * PGP Signed by an unknown key On Tue, Mar 18, 2014 at 04:51:32PM -0700, Arun Shamanna Lakshmi wrote: Currently soc_enum

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 04:51:32PM -0700, Arun Shamanna Lakshmi wrote: > Currently soc_enum structure supports only 2 registers (reg, reg2) > for kcontrol. However, it is possible to have multiple registers > per mux. This change allows us to control these multiple registers. I'd want to see a

[PATCH] ASoC: Add support for multi register mux

2014-03-18 Thread Arun Shamanna Lakshmi
Currently soc_enum structure supports only 2 registers (reg, reg2) for kcontrol. However, it is possible to have multiple registers per mux. This change allows us to control these multiple registers. Signed-off-by: Arun Shamanna Lakshmi Signed-off-by: Songhee Baek --- include/sound/soc.h |

[PATCH] ASoC: Add support for multi register mux

2014-03-18 Thread Arun Shamanna Lakshmi
Currently soc_enum structure supports only 2 registers (reg, reg2) for kcontrol. However, it is possible to have multiple registers per mux. This change allows us to control these multiple registers. Signed-off-by: Arun Shamanna Lakshmi ar...@nvidia.com Signed-off-by: Songhee Baek

Re: [PATCH] ASoC: Add support for multi register mux

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 04:51:32PM -0700, Arun Shamanna Lakshmi wrote: Currently soc_enum structure supports only 2 registers (reg, reg2) for kcontrol. However, it is possible to have multiple registers per mux. This change allows us to control these multiple registers. I'd want to see a user