Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-08 Thread Alexandre Belloni
On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote: > On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > > wrote: > > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > > > Ok, does

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-08 Thread Alexandre Belloni
On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote: > On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > > wrote: > > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > > > Ok, does that solve both randconfigs? > > > >

[PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-08 Thread Alexandre Belloni
SND_ATMEL_SOC_CLASSD selects SND_ATMEL_SOC_DMA but the driver itself handles its own DMA operations and doesn't need anything from atmel-pcm-dma.c or atmel_ssc_dai.c. Replace SND_ATMEL_SOC_DMA by SND_SOC_GENERIC_DMAENGINE_PCM which is the only one actually required. This may end up in a

[PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-08 Thread Alexandre Belloni
SND_ATMEL_SOC_CLASSD selects SND_ATMEL_SOC_DMA but the driver itself handles its own DMA operations and doesn't need anything from atmel-pcm-dma.c or atmel_ssc_dai.c. Replace SND_ATMEL_SOC_DMA by SND_SOC_GENERIC_DMAENGINE_PCM which is the only one actually required. This may end up in a

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > wrote: > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > Ok, does that solve both randconfigs? > > > > diff --git

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > wrote: > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > Ok, does that solve both randconfigs? > > > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > >

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni wrote: > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > Ok, does that solve both randconfigs? > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > index 4a56f3dfba51..dcee145dd179

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni wrote: > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > Ok, does that solve both randconfigs? > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > index 4a56f3dfba51..dcee145dd179 100644 > --- a/sound/soc/atmel/Kconfig >

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: > > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > >>

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: > > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > >> changed the way that the dependencies are

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 12:13, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: >> On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: >>> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") >>> changed the way

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 12:13, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: >> On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: >>> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") >>> changed the way that the dependencies are handled, but

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni wrote: > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") >> changed the way that the dependencies are handled, but then the >>

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni wrote: > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") >> changed the way that the dependencies are handled, but then the >> Class D amplifier support got merged,

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > changed the way that the dependencies are handled, but then the > Class D amplifier support got merged, which used the old method. > > This seems to have triggered a

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Alexandre Belloni
On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > changed the way that the dependencies are handled, but then the > Class D amplifier support got merged, which used the old method. > > This seems to have triggered a

[PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") changed the way that the dependencies are handled, but then the Class D amplifier support got merged, which used the old method. This seems to have triggered a very rare randconfig condition for me now, leading to a link error:

[PATCH] ASoC: atmel-classd: select correct Kconfig symbol

2017-12-05 Thread Arnd Bergmann
Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") changed the way that the dependencies are handled, but then the Class D amplifier support got merged, which used the old method. This seems to have triggered a very rare randconfig condition for me now, leading to a link error: