Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-22 Thread Wei Yongjun
On 10/22/2012 09:50 PM, Mark Brown wrote: > On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: >> From: Wei Yongjun >> >> The variable oldstatus is initialized but never used >> otherwise, so remove the unused variable. > Applied, thanks. However for changes like this you should really

Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-22 Thread Mark Brown
On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The variable oldstatus is initialized but never used > otherwise, so remove the unused variable. Applied, thanks. However for changes like this you should really consider in your changelog why the variable is

Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-22 Thread Mark Brown
On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable oldstatus is initialized but never used otherwise, so remove the unused variable. Applied, thanks. However for changes like this you should really consider in your

Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-22 Thread Wei Yongjun
On 10/22/2012 09:50 PM, Mark Brown wrote: On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable oldstatus is initialized but never used otherwise, so remove the unused variable. Applied, thanks. However for changes like

[PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-18 Thread Wei Yongjun
From: Wei Yongjun The variable oldstatus is initialized but never used otherwise, so remove the unused variable. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- sound/soc/soc-jack.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()

2012-10-18 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The variable oldstatus is initialized but never used otherwise, so remove the unused variable. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---