Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Charles Keepax wrote: > On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote: >> static void wm9713_soc_remove(struct snd_soc_component *component) >> { >> -#ifdef CONFIG_SND_SOC_AC97_BUS >> struct wm9713_priv *wm9713 = snd_soc_component_get_drvdata(component); >> >>

Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Charles Keepax wrote: > On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote: >> static void wm9713_soc_remove(struct snd_soc_component *component) >> { >> -#ifdef CONFIG_SND_SOC_AC97_BUS >> struct wm9713_priv *wm9713 = snd_soc_component_get_drvdata(component); >> >>

Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Charles Keepax
On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote: > gcc notices that without either the ac97 bus or the pdata, we never > initialize the regmap pointer, which leads to an uninitialized variable > access: > > sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe': >

Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Charles Keepax
On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote: > gcc notices that without either the ac97 bus or the pdata, we never > initialize the regmap pointer, which leads to an uninitialized variable > access: > > sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe': >

[PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
gcc notices that without either the ac97 bus or the pdata, we never initialize the regmap pointer, which leads to an uninitialized variable access: sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe': sound/soc/codecs/wm9712.c:666:2: error: 'regmap' may be used uninitialized in this

[PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

2018-11-02 Thread Arnd Bergmann
gcc notices that without either the ac97 bus or the pdata, we never initialize the regmap pointer, which leads to an uninitialized variable access: sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe': sound/soc/codecs/wm9712.c:666:2: error: 'regmap' may be used uninitialized in this