Re: [PATCH] Add non-zero module sections to sysfs

2013-04-11 Thread Philip Kranz
On Mon, Apr 08, 2013 at 01:44:45PM +0930, Rusty Russell wrote: > Philip Kranz writes: > > Hello. > > > > On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: > >> Just so you know: this isn't a parisc specific problem. Gcc produces > >> duplicate section names under various

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-11 Thread Philip Kranz
On Mon, Apr 08, 2013 at 01:44:45PM +0930, Rusty Russell wrote: Philip Kranz philip.kr...@googlemail.com writes: Hello. On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: Just so you know: this isn't a parisc specific problem. Gcc produces duplicate section names under

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-08 Thread Philip Kranz
On Mon, Apr 08, 2013 at 01:44:45PM +0930, Rusty Russell wrote: > Philip Kranz writes: > > I am not able to produce an object file with duplicate section names > > using gcc on x86. Even with -ffunction-sections, every section gets a > > unique name. Is this architecture-specific behaviour of gcc?

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-08 Thread Philip Kranz
On Mon, Apr 08, 2013 at 01:44:45PM +0930, Rusty Russell wrote: Philip Kranz philip.kr...@googlemail.com writes: I am not able to produce an object file with duplicate section names using gcc on x86. Even with -ffunction-sections, every section gets a unique name. Is this

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-07 Thread Rusty Russell
Philip Kranz writes: > Hello. > > On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: >> Just so you know: this isn't a parisc specific problem. Gcc produces >> duplicate section names under various circumstances, but the one that >> bites us is -ffunction-sections. Note that there

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-07 Thread Rusty Russell
Philip Kranz philip.kr...@googlemail.com writes: Hello. On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: Just so you know: this isn't a parisc specific problem. Gcc produces duplicate section names under various circumstances, but the one that bites us is

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
On 6-Apr-13, at 9:22 PM, James Bottomley wrote: John David Anglin wrote: On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
John David Anglin wrote: >On 6-Apr-13, at 6:52 AM, James Bottomley wrote: > >> On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says (version 1.1 page 1-15): >"An object

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says (version 1.1 page 1-15): "An object file may have more than one section with the

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: > > The problem is our assumption that section names be unique. This > > assumption is wrong. The ELF spec says (version 1.1 page 1-15): "An > > object file may have more than one section with the same name." We need > > to fix the kernel

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread Philip Kranz
Hello. On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: > Just so you know: this isn't a parisc specific problem. Gcc produces > duplicate section names under various circumstances, but the one that > bites us is -ffunction-sections. Note that there are proposals to use >

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread Philip Kranz
Hello. On Fri, Apr 05, 2013 at 12:07:15PM +0200, James Bottomley wrote: Just so you know: this isn't a parisc specific problem. Gcc produces duplicate section names under various circumstances, but the one that bites us is -ffunction-sections. Note that there are proposals to use

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says (version 1.1 page 1-15): An object file may have more than one section with the same name. We need to fix the kernel not to

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says (version 1.1 page 1-15): An object file may have more than one section with the same

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread James Bottomley
John David Anglin dave.ang...@bell.net wrote: On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong. The ELF spec says (version 1.1 page 1-15): An object

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-06 Thread John David Anglin
On 6-Apr-13, at 9:22 PM, James Bottomley wrote: John David Anglin dave.ang...@bell.net wrote: On 6-Apr-13, at 6:52 AM, James Bottomley wrote: On Sat, 2013-04-06 at 15:22 +1030, Rusty Russell wrote: The problem is our assumption that section names be unique. This assumption is wrong.

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
Sebastian Wankerl writes: > On 04/05/13 06:00, Rusty Russell wrote: >> Sebastian Wankerl writes: >>> On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl writes: > Add non-zero module sections to sysfs on architectures unequal to PARISC. > KGDB needs all module sections for

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
James Bottomley writes: > On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: >> Sebastian Wankerl writes: >> > On 04/04/13 03:00, Rusty Russell wrote: >> >> Sebastian Wankerl writes: >> >>> Add non-zero module sections to sysfs on architectures unequal to PARISC. >> >>> KGDB needs all

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Sebastian Wankerl
On 04/05/13 06:00, Rusty Russell wrote: > Sebastian Wankerl writes: >> On 04/04/13 03:00, Rusty Russell wrote: >>> Sebastian Wankerl writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore,

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread James Bottomley
On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: > Sebastian Wankerl writes: > > On 04/04/13 03:00, Rusty Russell wrote: > >> Sebastian Wankerl writes: > >>> Add non-zero module sections to sysfs on architectures unequal to PARISC. > >>> KGDB needs all module sections for proper module

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Sebastian Wankerl
On 04/05/13 06:00, Rusty Russell wrote: > Exactly. Don't workaround it here, revert it and put the > duplicate-section-name fixup in parisc where it belongs. > > Assuming parisc still produces these dup sections: that patch is 4 years > old now. > > Untested: > > diff --git

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Sebastian Wankerl
On 04/05/13 06:00, Rusty Russell wrote: Exactly. Don't workaround it here, revert it and put the duplicate-section-name fixup in parisc where it belongs. Assuming parisc still produces these dup sections: that patch is 4 years old now. Untested: diff --git a/arch/parisc/kernel/module.c

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread James Bottomley
On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Sebastian Wankerl
On 04/05/13 06:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
James Bottomley james.bottom...@hansenpartnership.com writes: On Fri, 2013-04-05 at 14:30 +1030, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-05 Thread Rusty Russell
Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/05/13 06:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-04 Thread Rusty Russell
Sebastian Wankerl writes: > On 04/04/13 03:00, Rusty Russell wrote: >> Sebastian Wankerl writes: >>> Add non-zero module sections to sysfs on architectures unequal to PARISC. >>> KGDB needs all module sections for proper module debugging. Therefore, >>> commit >>>

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-04 Thread Sebastian Wankerl
On 04/04/13 03:00, Rusty Russell wrote: > Sebastian Wankerl writes: >> Add non-zero module sections to sysfs on architectures unequal to PARISC. >> KGDB needs all module sections for proper module debugging. Therefore, >> commit >> 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-04 Thread Sebastian Wankerl
On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore, commit 35dead4235e2b67da7275b4122fed37099c2f462 is

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-04 Thread Rusty Russell
Sebastian Wankerl sisew...@cip.cs.fau.de writes: On 04/04/13 03:00, Rusty Russell wrote: Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore, commit

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-03 Thread Rusty Russell
Sebastian Wankerl writes: > Add non-zero module sections to sysfs on architectures unequal to PARISC. > KGDB needs all module sections for proper module debugging. Therefore, commit > 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC > architecture. #ifdef CONFIG_PARISC in

[PATCH] Add non-zero module sections to sysfs

2013-04-03 Thread Sebastian Wankerl
Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore, commit 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC architecture. Signed-off-by: Sebastian Wankerl Signed-off-by: Philip

Re: [PATCH] Add non-zero module sections to sysfs

2013-04-03 Thread Rusty Russell
Sebastian Wankerl sisew...@cip.cs.fau.de writes: Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore, commit 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC architecture. #ifdef

[PATCH] Add non-zero module sections to sysfs

2013-04-03 Thread Sebastian Wankerl
Add non-zero module sections to sysfs on architectures unequal to PARISC. KGDB needs all module sections for proper module debugging. Therefore, commit 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC architecture. Signed-off-by: Sebastian Wankerl sisew...@cip.cs.fau.de