Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 10:49 -0600, Eric W. Biederman wrote: > Rusty Russell <[EMAIL PROTECTED]> writes: > > > On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: > >> Do we really want to allow modules to be able to allocate page sized > >> per cpu memory. > > > > Hi Eric! > > > >

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Eric W. Biederman
Rusty Russell <[EMAIL PROTECTED]> writes: > On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: >> Do we really want to allow modules to be able to allocate page sized >> per cpu memory. > > Hi Eric! > > They always could, of course, they just wouldn't get correct alignment. > I

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: > Do we really want to allow modules to be able to allocate page sized > per cpu memory. Hi Eric! They always could, of course, they just wouldn't get correct alignment. I think the principle of least surprise says that if we

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Eric W. Biederman
Rusty Russell <[EMAIL PROTECTED]> writes: > [This was part of the GDT cleanups and per-cpu-> pda changes, which I > have revised, but this stands on its own. The only change is catching > the x86-64 per-cpu allocator too]. > == > Let's allow page-alignment in general for per-cpu data (wanted by

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Eric W. Biederman
Rusty Russell [EMAIL PROTECTED] writes: [This was part of the GDT cleanups and per-cpu- pda changes, which I have revised, but this stands on its own. The only change is catching the x86-64 per-cpu allocator too]. == Let's allow page-alignment in general for per-cpu data (wanted by Xen,

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: Do we really want to allow modules to be able to allocate page sized per cpu memory. Hi Eric! They always could, of course, they just wouldn't get correct alignment. I think the principle of least surprise says that if we

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Eric W. Biederman
Rusty Russell [EMAIL PROTECTED] writes: On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: Do we really want to allow modules to be able to allocate page sized per cpu memory. Hi Eric! They always could, of course, they just wouldn't get correct alignment. I think the

Re: [PATCH] Allow per-cpu variables to be page-aligned

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 10:49 -0600, Eric W. Biederman wrote: Rusty Russell [EMAIL PROTECTED] writes: On Wed, 2007-03-21 at 03:21 -0600, Eric W. Biederman wrote: Do we really want to allow modules to be able to allocate page sized per cpu memory. Hi Eric! They always could, of

[PATCH] Allow per-cpu variables to be page-aligned

2007-03-20 Thread Rusty Russell
[This was part of the GDT cleanups and per-cpu-> pda changes, which I have revised, but this stands on its own. The only change is catching the x86-64 per-cpu allocator too]. == Let's allow page-alignment in general for per-cpu data (wanted by Xen, and Ingo suggested KVM as well). Because larger

[PATCH] Allow per-cpu variables to be page-aligned

2007-03-20 Thread Rusty Russell
[This was part of the GDT cleanups and per-cpu- pda changes, which I have revised, but this stands on its own. The only change is catching the x86-64 per-cpu allocator too]. == Let's allow page-alignment in general for per-cpu data (wanted by Xen, and Ingo suggested KVM as well). Because larger