Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Jonathan Corbet
Oliver Pinter <[EMAIL PROTECTED]> wrote: > for stable (.22 .23 .24) ? > > git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f I sent it to the stable folks a couple days ago. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] -- To unsubscribe from this list: send the line

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Oliver Pinter
for stable (.22 .23 .24) ? git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f -- tested in: http://repo.or.cz/w/linux-2.6.22.y-op.git testing On 2/12/08, Jonathan Corbet <[EMAIL PROTECTED]> wrote: > Avoid buffer overflows in get_user_pages() > > So I spent a while pounding my head

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Oliver Pinter
for stable (.22 .23 .24) ? git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f -- tested in: http://repo.or.cz/w/linux-2.6.22.y-op.git testing On 2/12/08, Jonathan Corbet [EMAIL PROTECTED] wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Jonathan Corbet
Oliver Pinter [EMAIL PROTECTED] wrote: for stable (.22 .23 .24) ? git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f I sent it to the stable folks a couple days ago. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] -- To unsubscribe from this list: send the line

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-12 Thread Jiri Kosina
On Mon, 11 Feb 2008, Andrew Morton wrote: > > + if (len <= 0) > > + return 0; > > /* > > * Require read or write permissions. > > * If 'force' is set, we only require the "MAY" flags. > Can we just convert > do { > ... > } while (len); > into >

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-12 Thread Bodo Eggert
Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 11 Feb 2008 16:17:33 -0700 Jonathan Corbet <[EMAIL PROTECTED]> wrote: >> Avoid buffer overflows in get_user_pages() >> >> So I spent a while pounding my head against my monitor trying to figure >> out the vmsplice() vulnerability - how could a

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-12 Thread Bodo Eggert
Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 11 Feb 2008 16:17:33 -0700 Jonathan Corbet [EMAIL PROTECTED] wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-12 Thread Jiri Kosina
On Mon, 11 Feb 2008, Andrew Morton wrote: + if (len = 0) + return 0; /* * Require read or write permissions. * If 'force' is set, we only require the MAY flags. Can we just convert do { ... } while (len); into while (len)

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 16:17:33 -0700 Jonathan Corbet <[EMAIL PROTECTED]> wrote: > Avoid buffer overflows in get_user_pages() > > So I spent a while pounding my head against my monitor trying to figure > out the vmsplice() vulnerability - how could a failure to check for > *read* access turn into a

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 14:16, Robert Hancock wrote: > Nick Piggin wrote: > > On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: > >> Avoid buffer overflows in get_user_pages() > >> > >> So I spent a while pounding my head against my monitor trying to figure > >> out the vmsplice()

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Robert Hancock
Nick Piggin wrote: On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: > Avoid buffer overflows in get_user_pages() > > So I spent a while pounding my head against my monitor trying to figure > out the vmsplice() vulnerability - how could a failure to check for > *read* access turn into a root exploit? It

[PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Jonathan Corbet
Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root exploit? It turns out that it's a buffer overflow problem which is made easy by

[PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Jonathan Corbet
Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root exploit? It turns out that it's a buffer overflow problem which is made easy by

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 14:16, Robert Hancock wrote: Nick Piggin wrote: On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Robert Hancock
Nick Piggin wrote: On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Nick Piggin
On Tuesday 12 February 2008 10:17, Jonathan Corbet wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root exploit? It turns

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Andrew Morton
On Mon, 11 Feb 2008 16:17:33 -0700 Jonathan Corbet [EMAIL PROTECTED] wrote: Avoid buffer overflows in get_user_pages() So I spent a while pounding my head against my monitor trying to figure out the vmsplice() vulnerability - how could a failure to check for *read* access turn into a root