Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Marcel Holtmann
Hi Matthias, > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for > ROME controllers instantiated through ldisc, where the call causes a > crash due to a NULL pointer dereferentiation. Only call the

[PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Matthias Kaehlcke
qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer dereferentiation. Only call the function when we have a

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Matthias Kaehlcke
On Tue, Apr 23, 2019 at 07:26:40PM +0200, Marcel Holtmann wrote: > Hi Matthias, > > > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > > the HCI is always associated with a serdev device. This isn't true for > > ROME controllers instantiated through ldisc, where the call

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Marcel Holtmann
Hi Matthias, > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for > ROME controllers instantiated through ldisc, where the call causes a > crash due to a NULL pointer dereferentiation. Only call the

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-01 Thread Matthias Kaehlcke
Hi Marcel, do you have any comments or can this fix be landed? Thanks Matthias On Wed, Mar 13, 2019 at 04:52:19PM -0700, Matthias Kaehlcke wrote: > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for >

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-01 Thread Balakrishna Godavarthi
On 2019-03-14 05:22, Matthias Kaehlcke wrote: qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-03-21 Thread rjliao
在 2019-03-14 07:52，Matthias Kaehlcke 写道： qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer

[PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-03-13 Thread Matthias Kaehlcke
qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer dereferentiation. Only call the function when we have a