Re: [PATCH] CIFS should honour umask

2007-06-06 Thread Steve French
Thanks - it looks almost right but you missed mknod case and your patch had some whitespace/formatting problems. Could you try the following and make sure it works for you? If so will merge. diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index f085db9..8e86aac 100644 --- a/fs/cifs/dir.c +++

[PATCH] CIFS should honour umask

2007-06-06 Thread Matt Keenan
This patch makes CIFS honour a process' umask like other filesystems. Of course the server is still free to munge the permissions if it wants to; but the client will send the "right" permissions to begin with. A few caveats; 1) It only applies to filesystems that have CAP_UNIX (aka support unix

[PATCH] CIFS should honour umask

2007-06-06 Thread Matt Keenan
This patch makes CIFS honour a process' umask like other filesystems. Of course the server is still free to munge the permissions if it wants to; but the client will send the right permissions to begin with. A few caveats; 1) It only applies to filesystems that have CAP_UNIX (aka support unix

Re: [PATCH] CIFS should honour umask

2007-06-06 Thread Steve French
Thanks - it looks almost right but you missed mknod case and your patch had some whitespace/formatting problems. Could you try the following and make sure it works for you? If so will merge. diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index f085db9..8e86aac 100644 --- a/fs/cifs/dir.c +++