Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Mon, 2016-10-17 at 11:55 -0700, Dan Williams wrote: > On Mon, Oct 17, 2016 at 10:40 AM, Kani, Toshimitsu m> wrote: > > > > On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: > > > > > > On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > >  : > > > > > > >

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Mon, 2016-10-17 at 11:55 -0700, Dan Williams wrote: > On Mon, Oct 17, 2016 at 10:40 AM, Kani, Toshimitsu m> wrote: > > > > On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: > > > > > > On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > >  : > > > > > > > > > > > +static

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Dan Williams
On Mon, Oct 17, 2016 at 10:40 AM, Kani, Toshimitsu wrote: > On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: >> On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > : >> > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter >> > *iter, >> > +

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Dan Williams
On Mon, Oct 17, 2016 at 10:40 AM, Kani, Toshimitsu wrote: > On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: >> On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > : >> > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter >> > *iter, >> > + unsigned long

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: > On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:  : > > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter > > *iter, > > +  unsigned long *start) > > +{ > > + int rw = iov_iter_rw(iter); >

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: > On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:  : > > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter > > *iter, > > +  unsigned long *start) > > +{ > > + int rw = iov_iter_rw(iter); >

Re: [PATCH] DAX: enable iostat for read/write

2016-10-15 Thread Dave Chinner
On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still

Re: [PATCH] DAX: enable iostat for read/write

2016-10-15 Thread Dave Chinner
On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still

Re: [PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Kani, Toshimitsu
On Fri, 2016-10-14 at 10:35 -0700, Dan Williams wrote: > On Fri, Oct 14, 2016 at 10:25 AM, Toshi Kani > wrote: > > > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to

Re: [PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Kani, Toshimitsu
On Fri, 2016-10-14 at 10:35 -0700, Dan Williams wrote: > On Fri, Oct 14, 2016 at 10:25 AM, Toshi Kani > wrote: > > > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to users. > > > > Add

Re: [PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Dan Williams
On Fri, Oct 14, 2016 at 10:25 AM, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note,

Re: [PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Dan Williams
On Fri, Oct 14, 2016 at 10:25 AM, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still does not

[PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Toshi Kani
DAX IO path does not support iostat, but its metadata IO path does. Therefore, iostat shows metadata IO statistics only, which has been confusing to users. Add iostat support to the DAX read/write path. Note, iostat still does not support the DAX mmap path as it allows user applications to

[PATCH] DAX: enable iostat for read/write

2016-10-14 Thread Toshi Kani
DAX IO path does not support iostat, but its metadata IO path does. Therefore, iostat shows metadata IO statistics only, which has been confusing to users. Add iostat support to the DAX read/write path. Note, iostat still does not support the DAX mmap path as it allows user applications to