Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 06:53:06AM +0100, Willy Tarreau wrote: > At most, they will ask their distro vendor for continued support of the > feature (which there will be in the same minor release), and if vendors' > feedback show there is enough demand, then we will just have to delay the > remo

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Thu, Mar 22, 2007 at 01:02:50AM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 05:45:40AM +0100, Willy Tarreau wrote: > > On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > > > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > > > On Wed, Mar 21, 2007 at 07:43

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 05:45:40AM +0100, Willy Tarreau wrote: > On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > > > On Thu, Mar 22, 2007 at 12:

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > > > > > Then a printk() on e

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > > > Then a printk() on every open() should be enough. We've all been seeing > > > "Warning:

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > Then a printk() on every open() should be enough. We've all been seeing > > "Warning: tcpdump uses obsolete AF_PACKET"... and it finally disappeared. > > There's a

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Andrew Morton
On Wed, 21 Mar 2007 19:42:36 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Wed, Mar 21, 2007 at 04:27:17PM -0700, Andrew Morton wrote: > > > [1] Though admittedly the one in RHEL deviates from upstream > > > as it contains performance enhancements that were vetoed from > > > upstream accepta

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > Then a printk() on every open() should be enough. We've all been seeing > "Warning: tcpdump uses obsolete AF_PACKET"... and it finally disappeared. There's a difference. We have the source for tcpdump. Dave -- http://

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Wed, Mar 21, 2007 at 04:27:17PM -0700, Andrew Morton wrote: > > [1] Though admittedly the one in RHEL deviates from upstream > > as it contains performance enhancements that were vetoed from > > upstream acceptance due to it being "deprecated". > > What enhancements are they? Hmm, actuall

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Andrew Morton
On Wed, 21 Mar 2007 19:19:35 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Wed, Mar 21, 2007 at 03:19:52PM -0700, Andrew Morton wrote: > > > We've given people years of notice and _some_ applications have converted > > over to open("/dev/sda1", O_DIRECT), as they should. > > > > Sure, it'

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Wed, Mar 21, 2007 at 04:13:41PM -0700, Andrew Morton wrote: > On Thu, 22 Mar 2007 00:10:50 + > Alan Cox <[EMAIL PROTECTED]> wrote: > > > > > This is a user visible API it is therefore not elligable for removal > > > > anyway > > > > > > mutter. > > > > > > We've given people years of noti

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Wed, Mar 21, 2007 at 03:19:52PM -0700, Andrew Morton wrote: > We've given people years of notice and _some_ applications have converted > over to open("/dev/sda1", O_DIRECT), as they should. > > Sure, it's a small and simple driver (now), so the cost of maintaining it > is low. > > But

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Andrew Morton
On Thu, 22 Mar 2007 00:10:50 + Alan Cox <[EMAIL PROTECTED]> wrote: > > > This is a user visible API it is therefore not elligable for removal > > > anyway > > > > mutter. > > > > We've given people years of notice and _some_ applications have converted > > over to open("/dev/sda1", O_DIRECT)

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Alan Cox
> > This is a user visible API it is therefore not elligable for removal > > anyway > > mutter. > > We've given people years of notice and _some_ applications have converted > over to open("/dev/sda1", O_DIRECT), as they should. Linus said we don't break old applications by removing APIs. People

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Andrew Morton
On Tue, 20 Mar 2007 18:14:42 + Alan Cox <[EMAIL PROTECTED]> wrote: > On Tue, 20 Mar 2007 12:57:36 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > On Sun, Mar 18, 2007 at 04:57:57PM +0100, Andi Kleen wrote: > > > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > > > > > Delete the a

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-20 Thread Robert P. J. Day
On Tue, 20 Mar 2007, Alan Cox wrote: > On Tue, 20 Mar 2007 12:57:36 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > On Sun, Mar 18, 2007 at 04:57:57PM +0100, Andi Kleen wrote: > > > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > > > > > Delete the allegedly obsolete raw driver feature

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-20 Thread Alan Cox
On Tue, 20 Mar 2007 12:57:36 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Sun, Mar 18, 2007 at 04:57:57PM +0100, Andi Kleen wrote: > > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > > > Delete the allegedly obsolete raw driver feature, which has been > > > marked for death since 200

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-20 Thread Dave Jones
On Sun, Mar 18, 2007 at 04:57:57PM +0100, Andi Kleen wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > Delete the allegedly obsolete raw driver feature, which has been > > marked for death since 2005. > > I think it would be better to replace it with a wrapper > that forces O_D

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-18 Thread Robert P. J. Day
On Sun, 18 Mar 2007, Andi Kleen wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > Delete the allegedly obsolete raw driver feature, which has been > > marked for death since 2005. > > I think it would be better to replace it with a wrapper that forces > O_DIRECT and opens the underlyin

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-18 Thread Andi Kleen
"Robert P. J. Day" <[EMAIL PROTECTED]> writes: > Delete the allegedly obsolete raw driver feature, which has been > marked for death since 2005. I think it would be better to replace it with a wrapper that forces O_DIRECT and opens the underlying block device. I suspect just dropping it will br

[PATCH] Delete obsolete RAW driver feature.

2007-03-18 Thread Robert P. J. Day
Delete the allegedly obsolete raw driver feature, which has been marked for death since 2005. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- compile-tested with "make allyesconfig" under x86. Documentation/feature-removal-schedule.txt |8 Documentation/ioctl-number.txt