Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-17 Thread Tang Chen
On 10/17/2012 07:08 AM, Tejun Heo wrote: On Thu, Sep 27, 2012 at 05:19:46PM +0800, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So,

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-17 Thread Tang Chen
On 10/17/2012 07:08 AM, Tejun Heo wrote: On Thu, Sep 27, 2012 at 05:19:46PM +0800, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So,

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-16 Thread Tejun Heo
Hello, Sorry about the delay. Was traveling. On Thu, Sep 27, 2012 at 05:19:46PM +0800, Tang Chen wrote: > 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which > means the corresponding cpu has already dead. As a result, it won't be > accessed > in the

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-16 Thread Tejun Heo
Hello, Sorry about the delay. Was traveling. On Thu, Sep 27, 2012 at 05:19:46PM +0800, Tang Chen wrote: 1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-07 Thread Tang Chen
Hi all, Would you please help to review this patch ? Thanks. :) On 09/28/2012 03:54 PM, Lai Jiangshan wrote: Add CC: Tejun Heo, Peter Zijlstra. Hi, Tejun This is a bug whose root cause is the same as https://bugzilla.kernel.org/show_bug.cgi?id=47301. Acked-by: Lai Jiangshan thanks, Lai

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-10-07 Thread Tang Chen
Hi all, Would you please help to review this patch ? Thanks. :) On 09/28/2012 03:54 PM, Lai Jiangshan wrote: Add CC: Tejun Heo, Peter Zijlstra. Hi, Tejun This is a bug whose root cause is the same as https://bugzilla.kernel.org/show_bug.cgi?id=47301. Acked-by: Lai

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-09-28 Thread Lai Jiangshan
Add CC: Tejun Heo, Peter Zijlstra. Hi, Tejun This is a bug whose root cause is the same as https://bugzilla.kernel.org/show_bug.cgi?id=47301. Acked-by: Lai Jiangshan thanks, Lai On 09/27/2012 05:19 PM, Tang Chen wrote: > 1. cmci_rediscover() is only called by the CPU_POST_DEAD event

Re: [PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-09-28 Thread Lai Jiangshan
Add CC: Tejun Heo, Peter Zijlstra. Hi, Tejun This is a bug whose root cause is the same as https://bugzilla.kernel.org/show_bug.cgi?id=47301. Acked-by: Lai Jiangshan la...@cn.fujitsu.com thanks, Lai On 09/27/2012 05:19 PM, Tang Chen wrote: 1. cmci_rediscover() is only called by the

[PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-09-27 Thread Tang Chen
1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So, we could change the if(cpu == dying) statement into a BUG_ON(). 2. cmci_rediscover() used

[PATCH] Do not change worker's running cpu in cmci_rediscover().

2012-09-27 Thread Tang Chen
1. cmci_rediscover() is only called by the CPU_POST_DEAD event handler, which means the corresponding cpu has already dead. As a result, it won't be accessed in the for_each_online_cpu loop. So, we could change the if(cpu == dying) statement into a BUG_ON(). 2. cmci_rediscover() used